Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEX support #180

Closed
wants to merge 2 commits into from
Closed

VEX support #180

wants to merge 2 commits into from

Conversation

slashben
Copy link
Contributor

@slashben slashben commented Oct 24, 2023

PR Type:

Enhancement, Other


PR Description:

This PR introduces the following changes:

  • Adds support for VEX (Vulnerability Exchange) by implementing cleanup of VEX documents in storage.
  • Updates the 'go-cmp' dependency from v0.5.9 to v0.6.0.
  • Replaces the 'kubescape/storage' dependency with a specific version.

PR Main Files Walkthrough:

files:

watcher/watcher.go: Added a check to delete OpenVulnerabilityExchangeContainers if the instance ID is not recognized. This is part of the VEX support implementation.
go.mod: Updated the 'go-cmp' dependency version and replaced the 'kubescape/storage' dependency with a specific version.
go.sum: Updated the checksums for the updated and replaced dependencies.


User Description:

Overview

Adding support for VEX: cleanup of VEX document in storage. Part of this feature kubescape/kubevuln#155

Signed Commits

  • Yes, I signed my commits.

Signed-off-by: Ben <ben@armosec.io>
@dwertent
Copy link

dwertent commented Nov 1, 2023

@slashben is this ready?

@slashben
Copy link
Contributor Author

slashben commented Nov 1, 2023

@slashben is this ready?

Still waiting for @vladklokun to review

watcher/watcher.go Show resolved Hide resolved
@dwertent dwertent marked this pull request as ready for review November 1, 2023 08:59
@dwertent
Copy link

dwertent commented Nov 1, 2023

@slashben please rebase to main

@codiumai-pr-agent-free codiumai-pr-agent-free bot added enhancement New feature or request Other labels Nov 1, 2023
Copy link

PR Analysis

  • 🎯 Main theme: The main theme of this PR is to add support for VEX (Vulnerability Exchange) and update dependencies.
  • 📝 PR summary: This PR introduces support for VEX by implementing cleanup of VEX documents in storage. It also updates the 'go-cmp' dependency from v0.5.9 to v0.6.0 and replaces the 'kubescape/storage' dependency with a specific version.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
@dwertent
Copy link

We manage the delete in the storage

@dwertent dwertent closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants