Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContainerName #242

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Add ContainerName #242

merged 9 commits into from
Aug 26, 2024

Conversation

jnathangreeg
Copy link
Contributor

@jnathangreeg jnathangreeg commented Aug 25, 2024

Overview

This PR fixes #

Signed Commits

  • Yes, I signed my commits.

Signed-off-by: jnathangreeg <jonathang@armosec.io>
@jnathangreeg jnathangreeg added the release Create release label Aug 25, 2024
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: jnathangreeg <jonathang@armosec.io>
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: jnathangreeg <jonathang@armosec.io>
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

admission/rules/v1/helpers.go Outdated Show resolved Hide resolved
Signed-off-by: jnathangreeg <jonathang@armosec.io>
Signed-off-by: jnathangreeg <jonathang@armosec.io>
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: jnathangreeg <jonathang@armosec.io>
@jnathangreeg jnathangreeg requested review from idohuber and removed request for amitschendel August 25, 2024 15:28
idohuber
idohuber previously approved these changes Aug 25, 2024
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: jnathangreeg <jonathang@armosec.io>
Signed-off-by: jnathangreeg <jonathang@armosec.io>
@jnathangreeg jnathangreeg changed the title Add PodNamespace Add ContainerName Aug 26, 2024
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: jnathangreeg <jonathang@armosec.io>
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it 👍

Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@jnathangreeg jnathangreeg merged commit 4617c94 into main Aug 26, 2024
8 checks passed
@matthyx matthyx deleted the feature/incidents_aggregation branch October 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants