Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revise migrations #248

Merged
merged 7 commits into from
Dec 17, 2024
Merged

feat: revise migrations #248

merged 7 commits into from
Dec 17, 2024

Conversation

WitoDelnat
Copy link
Contributor

@WitoDelnat WitoDelnat commented Dec 16, 2024

  • Remove init containers. MongoDB connection and migrations are now awaited within the cloud-api main function.
  • Remove split between MongoDB migrations and indexing. This was causing problems where indexing happened before migrations. You cannot index a time series database before it's defined (and that happens in a migration).
  • Migrations now happen during Sync instead of a Pre/Post hook. These hooks were either too early (database does not exist yet) or too late (new code expects migrations to have happened or behaviour is unexepcted).

I originally had this PR, but I decided to start over to simplify changes necessary.

@WitoDelnat WitoDelnat requested a review from a team as a code owner December 16, 2024 09:35
@WitoDelnat WitoDelnat mentioned this pull request Dec 16, 2024
3 tasks
@WitoDelnat WitoDelnat force-pushed the rework-migrations-2 branch 4 times, most recently from 072859e to 9ad5c91 Compare December 16, 2024 16:41
# Conflicts:
#	charts/testkube-enterprise/Chart.lock
@WitoDelnat WitoDelnat merged commit b7b5678 into main Dec 17, 2024
4 checks passed
@WitoDelnat WitoDelnat deleted the rework-migrations-2 branch December 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants