ci: modify flow #49
ci: modify flow #49
Conversation
…d-charts into add-dispatch-main
…d-charts into add-dispatch-main
…d-charts into add-dispatch-main
.github/workflows/lint.yaml
Outdated
| git status -s -uno >> $GITHUB_STEP_SUMMARY | ||
| echo -e '```' >> $GITHUB_STEP_SUMMARY | ||
| echo "Generating helm-docs" | ||
| helm-docs |
There was a problem hiding this comment.
do you call helm-docs directly here?
There was a problem hiding this comment.
yes, so that we do not do this manually
There was a problem hiding this comment.
can we use the helper script from here https://github.com/kubeshop/testkube-cloud-charts/blob/develop/scripts/helm-docs.sh?
There was a problem hiding this comment.
you are right, changed the command to using the script!
| chart-test: | ||
| name: Chart lint | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
| ref: ${{ github.event.pull_request.head.ref }} |
There was a problem hiding this comment.
It checkouts the source branch; fetch-depth: 0 checks out a default one
.github/workflows/lint.yaml
Outdated
| with: | ||
| # Note: Also update in scripts/lint.sh | ||
| version: v3.7.1 | ||
| uses: helm/chart-testing-action@v2.4.0 |
There was a problem hiding this comment.
what is the difference?
There was a problem hiding this comment.
no difference, I put it back, I was just trying newer version.
| git commit -m "updating chart ${{ github.event.client_payload.app }} version to "${{ env.CHART_VERSION }}" and appVersion to ${{ github.event.client_payload.appVersion }}; Updating testkube-enterprise chart version to ${{ env.ENTERPRISE_CHART_VERSION }}." | ||
| git push | ||
| git push --set-upstream https://testkube-cloud-ci-bot:${{ secrets.GITHUB_TOKEN }}@github.com/kubeshop/testkube-cloud-charts main |
There was a problem hiding this comment.
why can't we push with regular permissions? Is the main branch protected?
There was a problem hiding this comment.
updated the command
There was a problem hiding this comment.
hmmm but why it won't work with just git push?
Checklist: