Adding Cucumber Test #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkonieczny any commennts? |
|
Hey @vsukhin thanks for reviewing this. Bruno has seen and approved and I have to update the repo links in the blog post, so I will go ahead and merge this. |
|
sure! go forward |
|
One thing - should we have spaces in directory names or underscores? Probably worth to consider some convention 🙂 |
rangoo94
reviewed
May 22, 2024
| @@ -0,0 +1,249 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Gradle Wrapper files should not be commited (jar/gradlew etc) and should be .gitignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code for Cucumber test using Gradle.