feat: resource execution metrics #6133
Open
+3,057
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejanzele
force-pushed
the
feat/resource-exec-metrics
branch
5 times, most recently
from
7963828 to
86e9358
Compare
dejanzele
changed the title
rangoo94
reviewed
Feb 21, 2025
cmd/testworkflow-init/main.go
Outdated
Comment on lines
270
to
272
| fmt.Printf("Actions: %v\n", state.Actions) | ||
| fmt.Printf("Step: %v\n", state.GetStep(action.Execute.Ref)) | ||
|
|
There was a problem hiding this comment.
debug log
Suggested change
| fmt.Printf("Actions: %v\n", state.Actions) | |
| fmt.Printf("Step: %v\n", state.GetStep(action.Execute.Ref)) |
cmd/testworkflow-init/main.go
Outdated
| Skip: action.Execute.Toolkit, | ||
| Workflow: d.InternalConfig.Workflow.Name, | ||
| Step: step.Ref, | ||
| Execution: d.InternalConfig.Execution.Id, |
There was a problem hiding this comment.
Maybe be worth to consider using Resource.Id too - it will differ on parallel steps and services
pkg/utilization/core/writers.go
Outdated
| if err != nil { | ||
| return errors.Wrapf(err, "failed to open file") | ||
| } | ||
| fmt.Println("Printing file content") |
There was a problem hiding this comment.
Suggested change
| fmt.Println("Printing file content") |
| if err != nil { | ||
| return errors.Wrapf(err, "failed to read file") | ||
| } | ||
| fmt.Println(string(data)) |
There was a problem hiding this comment.
Suggested change
| fmt.Println(string(data)) |
pkg/utilization/instrument.go
Outdated
Comment on lines
178
to
182
|
|
||
| // Print debug info | ||
| fmt.Printf("child process: %d\n", process.Pid) | ||
| name, _ := process.Name() | ||
| fmt.Printf("child process name: %s\n", name) |
There was a problem hiding this comment.
Suggested change
| // Print debug info | |
| fmt.Printf("child process: %d\n", process.Pid) | |
| name, _ := process.Name() | |
| fmt.Printf("child process name: %s\n", name) |
|
|
||
| } | ||
|
|
||
| func (r *MetricRecorder) Start(ctx context.Context) { |
There was a problem hiding this comment.
Likely information about starting/stopping should not be printed (unless debug)
There was a problem hiding this comment.
yep, all debug logs will be removed
pkg/utilization/utilisation.go
Outdated
|
|
||
| // Skip will be set to true for internal operations like git operations, artifact scraping... | ||
| if config.Skip { | ||
| stdoutUnsafe.Println("skipping metrics recording for internal operations") |
There was a problem hiding this comment.
Should it print about skipping?
cmd/testworkflow-init/main.go
Outdated
| commands.Run(*action.Execute, currentContainer) | ||
| d := data.GetState() | ||
| recorderConfig := utilization.Config{ | ||
| Dir: "./.tk/metrics", |
There was a problem hiding this comment.
It rather should be stored in /.tktw directory, along with other internal files (for sure not CWD)
cmd/testworkflow-init/main.go
Outdated
| Execution: d.InternalConfig.Execution.Id, | ||
| Format: core.FormatInflux, | ||
| } | ||
| utilization.WithMetricsRecorder(recorderConfig, func() { |
There was a problem hiding this comment.
I don't see the metrics output being saved as artifact - is it meant to be uploaded only when users request it specifically?
There was a problem hiding this comment.
updated to use internal artifact storage
rangoo94
reviewed
Feb 21, 2025
pkg/utilization/utilisation.go
Outdated
|
|
||
| process, err := getChildProcess() | ||
| if err != nil { | ||
| stdoutUnsafe.Errorf("failed to get process: %v", err) |
rangoo94
reviewed
Feb 21, 2025
pkg/utilization/utilisation.go
Outdated
Comment on lines
138
to
139
| stdoutUnsafe.Errorf("failed to create file writer: %v", err) | ||
| stdoutUnsafe.Warn("running the provided function without metrics recorder") |
dejanzele
changed the title
Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
dejanzele
force-pushed
the
feat/resource-exec-metrics
branch
from
d504acd to
0a2463c
Compare
dejanzele
force-pushed
the
feat/resource-exec-metrics
branch
from
0a2463c to
37c1c80
Compare
Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
dejanzele
force-pushed
the
feat/resource-exec-metrics
branch
from
37c1c80 to
1ada3ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Add resource execution metrics
Checklist (choose whats happened)
Breaking changes
Changes
Fixes