Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Tekton manifests to release ks #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide Tekton manifests to release ks #253

wants to merge 1 commit into from

Conversation

JohnNiang
Copy link
Contributor

What this PR dose

  • Provide Tekton manifests to release ks
  • Disable release workflow of GitHub Action

Test testify

Please see the release at https://github.com/JohnNiang/ks/releases/tag/v0.0.34.

Docker image built by Tekton:

ghcr.io/johnniang/ks/ks:v0.0.34
ghcr.io/johnniang/ks/ks:latest
johnniang/ks:v0.0.34
johnniang/ks:latest

image

@ks-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JohnNiang
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang
Provide Tekton manifests to release ks
b3deefa 
Signed-off-by: John Niang <johnniang@fastmail.com>
@JohnNiang JohnNiang force-pushed the refactor/release-by-tekton branch from 8e748fb to b3deefa Compare December 27, 2021 03:22
LinuxSuRen
LinuxSuRen reviewed Dec 27, 2021
View reviewed changes
.goreleaser.yml
Comment on lines +111 to +116
- goos: linux
goarch: amd64
dockerfile: build/Dockerfile
image_templates:
- "surenpi/ks-tool:v1.17.0-{{.Tag}}"
- "surenpi/ks-tool:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these about? Do we really need it?

.github/tekton/releaser-pipeline.yaml
- name: revision
description: Git repository revision to checkout.
# - name: dashboard-url
# description: Tekton dashboard access URL, like http://demo:31962/#/namespaces/ks/pipelineruns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing unused lines?

@ks-ci-bot
Copy link
Contributor

@JohnNiang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen left review comments

Assignees
No one assigned
Labels
needs-rebase size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnNiang @ks-ci-bot @LinuxSuRen