Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor extensions management using DataTable #4419

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

donniean
Copy link
Contributor

@donniean donniean commented Jan 8, 2025

What type of PR is this?

What this PR does / why we need it

Which issue(s) this PR fixes

Links #

Special notes for reviewers


Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc


Signed-off-by: donniean <donniean1@gmail.com>
@ks-ci-bot ks-ci-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2025
@donniean
Copy link
Contributor Author

donniean commented Jan 8, 2025

/cherry-pick master

@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…in Extensions component

Signed-off-by: donniean <donniean1@gmail.com>
Signed-off-by: donniean <donniean1@gmail.com>
@donniean
Copy link
Contributor Author

donniean commented Jan 8, 2025

/cc @yazhouio

@ks-ci-bot ks-ci-bot requested a review from yazhouio January 8, 2025 08:29
@donniean
Copy link
Contributor Author

donniean commented Jan 8, 2025

/hold

… layout

Signed-off-by: donniean <donniean1@gmail.com>
@donniean
Copy link
Contributor Author

donniean commented Jan 8, 2025

/unhold

@donniean
Copy link
Contributor Author

donniean commented Jan 8, 2025

/test pull-console-build

@yazhouio
Copy link
Member

yazhouio commented Jan 8, 2025

/lgtm

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 44627dabbaaa6a1ce2faf31185bff451e63e3224

@ks-ci-bot ks-ci-bot merged commit b934c37 into kubesphere:release-4.1 Jan 8, 2025
3 checks passed
@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request created: #4422

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants