Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐾 [MTV-1435] It is now possible to set "static IP" for none windows VMs - rephrase labels #1326

Merged
merged 1 commit into from
Sep 16, 2024
Merged

🐾 [MTV-1435] It is now possible to set "static IP" for none windows VMs - rephrase labels #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"Disk counter": "Disk counter",
"Disk decryption passphrases": "Disk decryption passphrases",
"Disk transfer": "Disk transfer",
"Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.": "Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.",
"Do not try to preserve the static IPs of virtual machines migrated from vSphere.": "Do not try to preserve the static IPs of virtual machines migrated from vSphere.",
"Domain": "Domain",
"Domain name": "Domain name",
"Drag and drop a file or upload one": "Drag and drop a file or upload one",
Expand Down Expand Up @@ -366,7 +366,7 @@
"Preserve CPU model": "Preserve CPU model",
"Preserve static IPs": "Preserve static IPs",
"Preserve the CPU model and flags the VM runs with in its oVirt cluster.": "Preserve the CPU model and flags the VM runs with in its oVirt cluster.",
"Preserve the static IPs of VMs with Windows guest operating system from vSphere.": "Preserve the static IPs of VMs with Windows guest operating system from vSphere.",
"Preserve the static IPs of virtual machines migrated from vSphere.": "Preserve the static IPs of virtual machines migrated from vSphere.",
"Product": "Product",
"Progress": "Progress",
"Project": "Project",
Expand Down
2 changes: 1 addition & 1 deletion ...lans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const PreserveStaticIPsDetailsItem: React.FC<PlanDetailsItemProps> = ({
const { showModal } = useModal();

const defaultHelpContent = t(
`Preserve the static IPs of VMs with Windows guest operating system from vSphere.`,
`Preserve the static IPs of virtual machines migrated from vSphere.`,
);

const trueLabel = (
Expand Down
8 changes: 3 additions & 5 deletions ...components/SettingsSection/modals/EditPlanPreserveStaticIPs/EditPlanPreserveStaticIPs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,9 @@ const PreserveStaticIPsInputFactory: () => ModalInputComponentType = () => {
return (
<Switch
id="simple-switch"
label={t(
'Preserve the static IPs of VMs with Windows guest operating system from vSphere.',
)}
label={t('Preserve the static IPs of virtual machines migrated from vSphere.')}
labelOff={t(
'Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.',
'Do not try to preserve the static IPs of virtual machines migrated from vSphere.',
)}
isChecked={value === 'true'}
onChange={onChangeInternal}
Expand All @@ -76,7 +74,7 @@ const EditPlanPreserveStaticIPs_: React.FC<EditPlanPreserveStaticIPsProps> = (pr
label={props?.label || t('Whether to preserve the static IPs')}
model={PlanModel}
onConfirmHook={onConfirm}
body={t(`Preserve the static IPs of VMs with Windows guest operating system from vSphere.`)}
body={t(`Preserve the static IPs of virtual machines migrated from vSphere.`)}
InputComponent={PreserveStaticIPsInputFactory()}
/>
);
Expand Down