Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using forEach instead of map as its return value is not being used #1341

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 30, 2024

Using forEach instead of map as its return value is not being used

@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 30, 2024
@yaacov yaacov added this to the 2.8.0 milestone Sep 30, 2024
@yaacov yaacov marked this pull request as ready for review September 30, 2024 09:31
Signed-off-by: yaacov <kobi.zamir@gmail.com>
@yaacov yaacov force-pushed the using-foreach-instead-of-map-in-card-items branch from e301fdc to fc3114e Compare September 30, 2024 09:31
Copy link

sonarcloud bot commented Sep 30, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.50%. Comparing base (13484d0) to head (fc3114e).
Report is 64 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   36.81%   36.50%   -0.31%     
==========================================
  Files         158      159       +1     
  Lines        2548     2586      +38     
  Branches      599      605       +6     
==========================================
+ Hits          938      944       +6     
- Misses       1428     1460      +32     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov yaacov merged commit 0e3a67c into kubev2v:main Sep 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants