Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume the resources are array #1345

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Oct 7, 2024

Don't assume the resources are array

Signed-off-by: yaacov <kobi.zamir@gmail.com>
@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 7, 2024
@yaacov yaacov added this to the 2.8.0 milestone Oct 7, 2024
@yaacov yaacov marked this pull request as ready for review October 7, 2024 07:59
Copy link

sonarcloud bot commented Oct 7, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.20%. Comparing base (13484d0) to head (78983db).
Report is 74 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
- Coverage   36.81%   36.20%   -0.61%     
==========================================
  Files         158      158              
  Lines        2548     2574      +26     
  Branches      599      613      +14     
==========================================
- Hits          938      932       -6     
- Misses       1428     1447      +19     
- Partials      182      195      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov yaacov merged commit 74ea537 into kubev2v:main Oct 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants