Fix 'not available' label for source mappings and disabled mappings issues #617
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
reviewed
Jul 26, 2023
| @@ -24,12 +24,17 @@ import { getBuilderItemsFromMapping } from './MappingBuilder/helpers'; | |||
| import { ProviderType } from 'legacy/src/common/constants'; | |||
| import { getStorageTitle } from 'legacy/src/common/helpers'; | |||
|
|
|||
| const domainAndNameToName = (domainnAndName: string): string => { | |||
| const match = domainnAndName.match(/\/([-a-z0-9]*)\/?$/); | |||
| return match ? match[1] : domainnAndName; | |||
There was a problem hiding this comment.
Suggested change
| return match ? match[1] : domainnAndName; | |
| return domainnAndNam.split('/')?.[1] || domainnAndNam; |
can you try split ?
https://github.com/kubev2v/forklift/blob/main/pkg/controller/plan/adapter/ocp/validator.go#L155
…ssues Fix two regression issues generated by a previous patch fix kubev2v#614 Issue 1: Before: all source mapping labels were displayed as 'Not available'. After the fix: source storage and network mappings names should be displayed for all provider types. Issues 2: Before: when trying to choose an exisiting mapping via the plan wizard, all mapping options were disabled and therefore can't be chosen even if fits. After the fix: fits mapping options shoule be enabled for selection via the plan wizard. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch
force-pushed
the
fix_not_available_sources_and_disabled_maps
branch
from
fe17e03
to
4d6769c
Compare
yaacov
added
the
enhancement
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two regression issues generated by a previous patch fix
Issue 1:
Before: all source mapping labels were displayed as 'Not available'.
After the fix: source storage and network mappings names should be displayed for all provider types.
Issues 2:
Before: when trying to choose an exisiting mapping via the plan wizard, all mapping options were disabled and therefore can't be chosen even if fits.
After the fix: suitable mapping options shoule be enabled for selection via the plan wizard.