Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canPatch to plan duplicat action dependencies #675

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add canPatch to plan duplicat action dependencies #675

merged 1 commit into from
Aug 9, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Aug 9, 2023 •
edited
Loading

Ref: #676

Issue:
the plan duplicate action is always disabled because canPatch is never updated

Fix:
add canPatch to the action dependencies

Screenshot:
Before:
plan-duplicate-before

After:
plan-duplicate-after

@yaacov
Add canPatch to plan duplicat action dependencies
8d52fc3 
Signed-off-by: yaacov <yzamir@redhat.com>
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Aug 9, 2023
@yaacov yaacov added this to the 2.5.0 milestone Aug 9, 2023
@yaacov yaacov added the QE label Aug 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yaacov yaacov merged commit 8b6bb3a into kubev2v:main Aug 9, 2023
5 checks passed
@yaacov yaacov mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug. QE
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@yaacov