Remote providers web UI link #597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardHoch
force-pushed
the
external_ui_link
branch
from
b7adfe0 to
c3f2822
Compare
mpershina
reviewed
Dec 4, 2024
RichardHoch
force-pushed
the
external_ui_link
branch
from
c3f2822 to
b855b81
Compare
|
@sgratch Please review this PR. |
|
@sgratch please review |
sgratch
reviewed
Jan 9, 2025
There was a problem hiding this comment.
@RichardHoch
As mentioned here, maybe worth adding that If the field is not set by user, a default UI link is calculated if possible (if not possible then an empty value is set).
Details:
The field value in the ui is fetched from yaml:
But if it's not set by the user and left empty, we try to auto calculate it based on the standard ui link url format per provider.
So You can see for example for vsphere provider that there is a link even though user didn't set it:
|
@sgratch I made the change you suggested. Please review this PR again. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTV-1145 by adding instructions about how to connect to a remote provider's UI, for all providers except OVA..
Preview: https://file.corp.redhat.com/rhoch/external_ui_link/html-single/#adding-source-providers [section 4.4.1.1., step 8; appears for all providers except OVA]