Look for annotation on NAD to set transfer route #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Plan controller will now look for an annotation `forklift.konveyor.io/route` on the NetworkAttachmentDefinition that was specified as the transfer network for the Plan. The annotation is expected to have a single IP address as its value, which will be set as the default route when configuring the secondary network on the importer pods. The annotation is optional, but if it is present then the Plan validator will ensure that its value is a valid IP address. Signed-off-by: Sam Lucidi <slucidi@redhat.com>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
==========================================
- Coverage 15.65% 15.61% -0.04%
==========================================
Files 112 112
Lines 23130 23188 +58
==========================================
Hits 3620 3620
- Misses 19222 19280 +58
Partials 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnecas
reviewed
Dec 5, 2024
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Plan controller will now look for an annotation
forklift.konveyor.io/routeon the NetworkAttachmentDefinition that was specified as the transfer network for the Plan.The annotation is expected to have a single IP address as its value, which will be set as the default route when configuring the secondary network on the importer pods.
The annotation is optional, but if it is present then the Plan validator will ensure that its value is a valid IP address.
Replaces #1241