Backport to 2.7.6 #1254

mnecas · 2024-12-09T16:13:48Z

Backport of:

Issue: When CDI is managing lot of DVs at once it can take some time before the CDI reconciles the DVs status and start the import. In the function `updateCopyProgress` we check the DV status and if it is paused we do continue and as next phase we have snapshot removal. So if the DV is still in paused state and we start the cutover and MTV skips over the phase thinking it already finished as the DV is in paused. Fix: Add WaitForDataVolumesStatus phase to wait until the DVs do not have the paused status. Ref: https://issues.redhat.com/browse/MTV-1717 https://github.com/kubev2v/forklift/blob/ea83264881b3dcd4a88dd627c1ca75da2483f408/pkg/controller/plan/migration.go#L1573-L1575 Signed-off-by: Martin Necas <mnecas@redhat.com>

Issue: The migration fails with `Another task is already in progress`. This is caused because of the snapshot creation is started right after snapshot removal and the snapshot removal did not finish due to the consolidation. Fix: I have added a timeout which users can control using the `controller_snapshot_removal_check_retries` variable. This will wait some time right after snapshot removal. This is just a temporary solution to unblock the users. I'll fix it properly using the VM events and tasks, but that will require a lot of changes in the controller inventory and main. Ref: https://issues.redhat.com/browse/MTV-1753 Signed-off-by: Martin Necas <mnecas@redhat.com>