MTV-1632 | Add secureboot to vsphere #1260
Conversation
| // We don't distinguish between UEFI and UEFI with secure boot, but we anyway would have | ||
| // disabled secure boot, even if we knew it was enabled on the source, because the guest | ||
| // OS won't be able to boot without getting the NVRAM data. By starting the VM without | ||
| // secure boot we ease the procedure users need to do in order to make a guest OS that | ||
| // was previously configured with secure boot bootable. |
There was a problem hiding this comment.
We need to make difference between measured boot and secureboot, the comment about the NVRAM is true but that contains the keys for the measured boot. Which still won't work, but we can manage the secureboot itself.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
- Coverage 15.57% 15.57% -0.01%
==========================================
Files 112 112
Lines 23255 23256 +1
==========================================
- Hits 3623 3621 -2
- Misses 19345 19347 +2
- Partials 287 288 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue: When creating the VM from vSphere on kubevirt the MTV always defaulted the secureboot to false. Fix: Add the secureboot to the inventory and to main controller to pass it to the KubeVirt. Ref: https://issues.redhat.com/browse/MTV-1632 Signed-off-by: Martin Necas <mnecas@redhat.com>
|
Issue: When creating the VM from vSphere on kubevirt the MTV always
defaulted the secureboot to false.
Fix: Add the secureboot to the inventory and to main controller to pass
it to the KubeVirt.
Ref: https://issues.redhat.com/browse/MTV-1632
Signed-off-by: Martin Necas mnecas@redhat.com