-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting storage mappings for OVA disks #1266
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
- Coverage 15.61% 15.42% -0.20%
==========================================
Files 112 112
Lines 23134 23426 +292
==========================================
+ Hits 3612 3613 +1
- Misses 19237 19528 +291
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e6fcebf
to
b93aaca
Compare
8e34905
to
266950c
Compare
* Exposes OVA appliance disks as mappable storage in the OVA inventory collector. * Permits mapping any or all OVA appliance disks to their own destination storage classes. * Any disks that are not specifically mapped are assigned to a default storage class, which must be given a storage mapping. Signed-off-by: Sam Lucidi <slucidi@redhat.com>
266950c
to
f4e7850
Compare
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, before merging this we need to sync with the UI and docs
Implements #1213
Note: Please ignore
default
mapping in below screenshots, the default mapping has been removed.