-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTV-1865 | Remove the q35 machine type #1291
Conversation
Issue: VMs imported from vSphere always have the q35 machine type set. but the machine type is "floating", and thus the VM abi can change between reboots (i.e. update from rhel 8 to rhel9 or 10 on the host side). Fix: Remove the q35 machine type. Ref: https://issues.redhat.com/browse/MTV-1865 Signed-off-by: Martin Necas <mnecas@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
- Coverage 15.47% 15.44% -0.03%
==========================================
Files 112 112
Lines 23399 23388 -11
==========================================
- Hits 3621 3613 -8
Misses 19490 19490
+ Partials 288 285 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -407,8 +407,6 @@ func (r *Builder) mapInput(vm *model.Workload, object *cnv.VirtualMachineSpec) { | |||
} | |||
|
|||
func (r *Builder) mapResources(vm *model.Workload, object *cnv.VirtualMachineSpec, usesInstanceType bool) { | |||
// KubeVirt supports Q35 or PC-Q35 machine types only. | |||
object.Template.Spec.Domain.Machine = &cnv.Machine{Type: Q35} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Q35
definition. Should we drop it as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nice catch, I have also removed additional OpenStack machinetype settings
Signed-off-by: Martin Necas <mnecas@redhat.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue:
VMs imported from vSphere always have the q35 machine type set. but the machine type is "floating", and thus the VM abi can change between reboots (i.e. update from rhel 8 to rhel9 or 10 on the host side).
Fix:
Remove the q35 machine type.
Ref: https://issues.redhat.com/browse/MTV-1865