Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1865 | Remove the q35 machine type #1291

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Jan 6, 2025

Issue:
VMs imported from vSphere always have the q35 machine type set. but the machine type is "floating", and thus the VM abi can change between reboots (i.e. update from rhel 8 to rhel9 or 10 on the host side).

Fix:
Remove the q35 machine type.

Ref: https://issues.redhat.com/browse/MTV-1865

@mnecas mnecas requested a review from yaacov as a code owner January 6, 2025 13:41
@mnecas mnecas added this to the 2.7.8 milestone Jan 6, 2025
Issue:
VMs imported from vSphere always have the q35 machine type set. but the machine type is "floating", and thus the VM abi can change between reboots (i.e. update from rhel 8 to rhel9 or 10 on the host side).

Fix:
Remove the q35 machine type.

Ref: https://issues.redhat.com/browse/MTV-1865

Signed-off-by: Martin Necas <mnecas@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.44%. Comparing base (bfb0a81) to head (6c1599f).
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   15.47%   15.44%   -0.03%     
==========================================
  Files         112      112              
  Lines       23399    23388      -11     
==========================================
- Hits         3621     3613       -8     
  Misses      19490    19490              
+ Partials      288      285       -3     
Flag Coverage Δ
unittests 15.44% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -407,8 +407,6 @@ func (r *Builder) mapInput(vm *model.Workload, object *cnv.VirtualMachineSpec) {
}

func (r *Builder) mapResources(vm *model.Workload, object *cnv.VirtualMachineSpec, usesInstanceType bool) {
// KubeVirt supports Q35 or PC-Q35 machine types only.
object.Template.Spec.Domain.Machine = &cnv.Machine{Type: Q35}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Q35 definition. Should we drop it as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice catch, I have also removed additional OpenStack machinetype settings

Signed-off-by: Martin Necas <mnecas@redhat.com>
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mnecas mnecas merged commit 70bcfae into kubev2v:main Jan 7, 2025
16 checks passed
@mnecas mnecas mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants