MTV-1866 | Remove the requests.memory from the builder #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: MTV is importing VMs with the requests.memory field and the memory.guest field set. This is problematic as it prevents memor-overcommit and is causing un-necessary memory pressure on VMs in the worst case leading to OOM sitiations. Fix: Remove the requests.memory from the builders Ref: https://issues.redhat.com/browse/MTV-1866 Signed-off-by: Martin Necas <mnecas@redhat.com>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 15.48% 15.45% -0.04%
==========================================
Files 112 112
Lines 23399 23380 -19
==========================================
- Hits 3624 3613 -11
+ Misses 19488 19482 -6
+ Partials 287 285 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fabiand
reviewed
Jan 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
MTV is importing VMs with the requests.memory field and the memory.guest field set. This is problematic as it prevents memor-overcommit and is causing un-necessary memory pressure on VMs in the worst case leading to OOM sitiations.
Fix:
Remove the requests.memory from the builders
Ref: https://issues.redhat.com/browse/MTV-1866