Skip to content

xcopy-populator: Use the make 'build' target to build the container #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

rgolangh
Copy link
Contributor

@rgolangh rgolangh commented Jun 4, 2025

The build target contains the needed build tags to make sure the VIB
version is injected into the binary

Signed-off-by: Roy Golan rgolan@redhat.com

@rgolangh
Copy link
Contributor Author

rgolangh commented Jun 4, 2025

@solenoci @borod108 @mnecas ptal

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.34%. Comparing base (f1fe5d0) to head (3c5ca32).
Report is 322 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #1948      +/-   ##
=========================================
- Coverage   15.45%   9.34%   -6.12%     
=========================================
  Files         112     360     +248     
  Lines       23377   48407   +25030     
=========================================
+ Hits         3613    4523     +910     
- Misses      19479   43519   +24040     
- Partials      285     365      +80     
Flag Coverage Δ
unittests 9.34% <ø> (-6.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgolangh
Copy link
Contributor Author

rgolangh commented Jun 6, 2025 via email

@rgolangh rgolangh force-pushed the use-make-for-container-build branch 7 times, most recently from 4cdfcd3 to e1f99f6 Compare June 8, 2025 19:11
The build target contains the needed build tags to make sure the VIB
version is injected into the binary

Signed-off-by: Roy Golan <rgolan@redhat.com>
@rgolangh rgolangh force-pushed the use-make-for-container-build branch from e1f99f6 to 3c5ca32 Compare June 8, 2025 19:16
Copy link

sonarqubecloud bot commented Jun 8, 2025

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mnecas mnecas merged commit 483536e into kubev2v:main Jun 9, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants