-
Notifications
You must be signed in to change notification settings - Fork 63
xcopy-populator: Use the make 'build' target to build the container #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
=========================================
- Coverage 15.45% 9.34% -6.12%
=========================================
Files 112 360 +248
Lines 23377 48407 +25030
=========================================
+ Hits 3613 4523 +910
- Misses 19479 43519 +24040
- Partials 285 365 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build with the make file failed https://github.com/kubev2v/forklift/pull/1948/checks?check_run_id=43474595753
On Thu, 5 Jun 2025 at 13:22, Martin Nečas ***@***.***> wrote:
***@***.**** commented on this pull request.
The build with the make file failed
https://github.com/kubev2v/forklift/pull/1948/checks?check_run_id=43474595753
I don't have permissions to view the konflux tenant namespace so I don't
see the underlying error. can you help maybe with the error from konflux?
I can't find cachi2 or something similar in the repo folders, including the
hidden ones
…
Reply to this email directly, view it on GitHub
<#1948 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGBYHDAQI3MPLPI3KWQDVT3CAK5VAVCNFSM6AAAAAB6S3VHKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOJZG4ZTQNZTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
4cdfcd3
to
e1f99f6
Compare
The build target contains the needed build tags to make sure the VIB version is injected into the binary Signed-off-by: Roy Golan <rgolan@redhat.com>
e1f99f6
to
3c5ca32
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The build target contains the needed build tags to make sure the VIB
version is injected into the binary
Signed-off-by: Roy Golan rgolan@redhat.com