Skip to content

Fix the build of virt-v2v images #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2023
Merged

Fix the build of virt-v2v images #625

merged 1 commit into from
Oct 15, 2023

Conversation

liranr23
Copy link
Member

@liranr23 liranr23 commented Oct 15, 2023 •
edited
Loading

After upgrading io_bazel_rules_docker, there is a requirment to have com_github_pkg_errors.

Analyzing: target //:push-forklift-virt-v2v (47 packages loaded, 519 targets configured)
ERROR: /home/runner/.cache/bazel/_bazel_runner/77ef990d3c7f0c39ee8ff0e654aac8c8/external/io_bazel_rules_docker/container/go/cmd/pusher/BUILD:22:11: no such package '@com_github_pkg_errors//': The repository '@com_github_pkg_errors' could not be resolved: Repository '@com_github_pkg_errors' is not defined and referenced by '@io_bazel_rules_docker//container/go/cmd/pusher:go_pusher'
ERROR: Analysis of target '//:push-forklift-virt-v2v' failed; build aborted:

@liranr23
Fix the build of virt-v2v images
56a9fd4 
After upgrading io_bazel_rules_docker, there is a requirment to have
com_github_pkg_errors.

Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
@liranr23 liranr23 requested a review from nyoxi as a code owner October 15, 2023 13:47
@liranr23 liranr23 requested a review from ahadas October 15, 2023 13:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

ahadas
ahadas approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to avoid depending on archived/deprecated library but as a temporary solution it's alright

@ahadas ahadas merged commit 463acb8 into kubev2v:main Oct 15, 2023
@liranr23 liranr23 deleted the fix_v2v_build branch October 15, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@nyoxi nyoxi Awaiting requested review from nyoxi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liranr23 @ahadas