Add support of direct FC storage from oVirt #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
force-pushed
the
direct_fcs
branch
2 times, most recently
from
2a86e92 to
54105ab
Compare
bennyz
reviewed
Nov 21, 2023
liranr23
commented
Nov 27, 2023
ahadas
reviewed
Nov 28, 2023
There was a problem hiding this comment.
nice
as we talked offline - it would have been better to add the version to the data in the inventory so that we can add a validation in the validation-service that is displayed when selecting the VMs, but that's good enough now that we declare that we only support RHV 4.4 SP1
that's a bit confusing because there's LUN storage domains in oVirt, please change to |
ahadas
reviewed
Nov 28, 2023
liranr23
force-pushed
the
direct_fcs
branch
3 times, most recently
from
d27e98b to
0cc5c7c
Compare
When dealing with FC storage, we need the ID of that LUN in order to map it. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
When having FC create the right PV for it. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
This patch will check the source provider version when it's oVirt provider and we have a direct LUN/FC to migrate. It will make sure we can support direct LUN/FC migration with enough API details from ovirt to do so. The minimal required version of ovirt is ovirt-engine-4.5.2.1 based on the PR: oVirt/ovirt-engine@e7c1f58 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Dec 3, 2023
ahadas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow migrations of direct FC disks from oVirt.
https://issues.redhat.com/browse/MTV-659