openstack: convert qcow2 snapshots for image based VMs #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
openstack-add-snapshot-conversion
branch
3 times, most recently
from
c68afe1 to
325b1fb
Compare
ahadas
reviewed
Jan 2, 2024
bennyz
force-pushed
the
openstack-add-snapshot-conversion
branch
2 times, most recently
from
271145a to
c45587a
Compare
bennyz
commented
Jan 3, 2024
bennyz
changed the title
bennyz
force-pushed
the
openstack-add-snapshot-conversion
branch
from
4c2d93b to
d579b2c
Compare
ahadas
reviewed
Jan 8, 2024
ahadas
reviewed
Jan 8, 2024
bennyz
force-pushed
the
openstack-add-snapshot-conversion
branch
5 times, most recently
from
4807ac1 to
4a84c3c
Compare
bennyz
commented
Jan 9, 2024
ahadas
reviewed
Jan 9, 2024
| for _, image := range images { | ||
| if imageID, ok := image.Properties[forkliftPropertyOriginalImageID]; ok && imageID == workload.ImageID { | ||
| annotations[planbase.AnnRequiresConversion] = "true" |
There was a problem hiding this comment.
how about:
Suggested change
| annotations[planbase.AnnRequiresConversion] = "true" | |
| // these are always qcow2 images that need to be converted to raw | |
| annotations[planbase.AnnRequiresConversion] = "true" |
ahadas
reviewed
Jan 9, 2024
| for _, image := range images { | ||
| if imageID, ok := image.Properties[forkliftPropertyOriginalImageID]; ok && imageID == workload.ImageID { | ||
| annotations[planbase.AnnRequiresConversion] = "true" |
There was a problem hiding this comment.
you told me you'll add a test of the format here - that would be better
bennyz
force-pushed
the
openstack-add-snapshot-conversion
branch
2 times, most recently
from
6b35b03 to
1be0321
Compare
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Missing completedPVCs++ when noticing the successful job Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
When a VM has both image and volumes attached, set the boot order to prefer the image if the volumes aren't bootable Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
instead of setting as qcow2 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
openstack-add-snapshot-conversion
branch
from
02941b9 to
db2aac1
Compare
|
ahadas
approved these changes
Jan 10, 2024
| for _, pvc := range persistentVolumeClaims { | ||
| // Handle loopvar https://go.dev/wiki/LoopvarExperiment |
There was a problem hiding this comment.
it would be great to upgrade to go 1.21 when we can not only to get rid of this thingie but also to have slice.Contains ;)
| @@ -842,7 +911,7 @@ func (r *KubeVirt) GetPodsWithLabels(podLabels map[string]string) (pods *core.Po | |||
| } | |||
|
|
|||
| // Deletes an object from destination cluster associated with the VM. | |||
| func (r *KubeVirt) DeleteObject(object client.Object, vm *plan.VMStatus, message, objType string) (err error) { | |||
| func (r *KubeVirt) DeleteObject(object client.Object, vm *plan.VMStatus, message, objType string, options ...client.DeleteOption) (err error) { | |||
There was a problem hiding this comment.
options is unused but ok, it should be at some point
There was a problem hiding this comment.
ah yes, I tried PropagationPolicy again 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently introduces the image-converter image that will perform the conversion. It has to jobs:
forklift-controller will create an additional PVC for the output of the conversion
convertcommand and will perform the conversion itself