Skip to content

Commit

Permalink
Drop use of dedicatedCPUPlacement
Browse files Browse the repository at this point in the history
A recent change to KubeVirt [1][2] has essentially disabled the use of
dedicatedCPUPlacement as we have no way of expressing the required
resource requirements through instance types at present.

Until this is corrected all requests to create instance types with this
attribute will be rejected. This change drops the use of this attribute
until this is resolved.

[1] kubevirt/kubevirt#8886
[2] kubevirt/kubevirt#8867

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
  • Loading branch information
lyarwood committed Dec 13, 2022
1 parent 2ae8947 commit d929205
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 13 deletions.
3 changes: 0 additions & 3 deletions common-clusterinstancetypes-bundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ metadata:
name: highperformance.large
spec:
cpu:
dedicatedCPUPlacement: true
guest: 2
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -24,7 +23,6 @@ metadata:
name: highperformance.medium
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -40,7 +38,6 @@ metadata:
name: highperformance.small
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand Down
6 changes: 0 additions & 6 deletions common-instancetypes-all-bundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ metadata:
name: highperformance.large
spec:
cpu:
dedicatedCPUPlacement: true
guest: 2
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -24,7 +23,6 @@ metadata:
name: highperformance.medium
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -40,7 +38,6 @@ metadata:
name: highperformance.small
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand Down Expand Up @@ -899,7 +896,6 @@ metadata:
name: highperformance.large
spec:
cpu:
dedicatedCPUPlacement: true
guest: 2
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -915,7 +911,6 @@ metadata:
name: highperformance.medium
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -931,7 +926,6 @@ metadata:
name: highperformance.small
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand Down
3 changes: 0 additions & 3 deletions common-instancetypes-bundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ metadata:
name: highperformance.large
spec:
cpu:
dedicatedCPUPlacement: true
guest: 2
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -24,7 +23,6 @@ metadata:
name: highperformance.medium
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand All @@ -40,7 +38,6 @@ metadata:
name: highperformance.small
spec:
cpu:
dedicatedCPUPlacement: true
guest: 1
isolateEmulatorThread: true
ioThreadsPolicy: shared
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ spec:
ioThreadsPolicy: shared
cpu:
isolateEmulatorThread: true
dedicatedCPUPlacement: true

0 comments on commit d929205

Please sign in to comment.