Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM lists are maintained with bazeldnf & 3 different configuration files, but its configuration & use here is not documented #3089

Closed
cfilleke opened this issue Jan 26, 2024 · 1 comment · Fixed by #3090 or #3409

Comments

@cfilleke
Copy link
Collaborator

Description:
It would be helpful for there to be a README.md in the rpm directory instructing maintainers on the configuration of bazeldnf parameters to populate the rpm lists in rpm/BUILD.bazel via the files .bazelrc, repo.yaml and hack/build/rpm-defs.sh, the fact that bazeldnf needs to be invoked through the make target rpm-defs, and also an indication that bazeldnf needs to be installed on the build host in order as it is not present in the builder image.

What you expected:
I would expect it to be documented how the pinned rpm lists in rpm/BUILD.bazel are maintained and generated

URL:
There isn't any documentation specific to maintaining the Kubevirt CDI code; bazeldnf is documented here: https://github.com/rmohr/bazeldnf

Additional context:
bazeldnf is now being released for s390x as well as ppc64le, arm, x86 and so forth: https://github.com/rmohr/bazeldnf/releases/tag/v0.5.9-rc2

cfilleke added a commit to cfilleke/containerized-data-importer that referenced this issue Jan 26, 2024
issue kubevirt#3089 It would be helpful for there to be a README.md in the rpm directory instructing maintainers on the configuration of bazeldnf parameters to populate the rpm lists in rpm/BUILD.bazel via the files .bazelrc, repo.yaml and hack/build/rpm-defs.sh, the fact that bazeldnf needs to be invoked through the make target rpm-defs, and also an indication that bazeldnf needs to be installed on the build host in order as it is not present in the builder image.

Signed-off-by: cfillekes <cfilleke@redhat.com>
kubevirt-bot pushed a commit that referenced this issue Feb 3, 2024
* Create README.md

issue #3089 It would be helpful for there to be a README.md in the rpm directory instructing maintainers on the configuration of bazeldnf parameters to populate the rpm lists in rpm/BUILD.bazel via the files .bazelrc, repo.yaml and hack/build/rpm-defs.sh, the fact that bazeldnf needs to be invoked through the make target rpm-defs, and also an indication that bazeldnf needs to be installed on the build host in order as it is not present in the builder image.

Signed-off-by: cfillekes <cfilleke@redhat.com>

* Update rpm/README.md

Correct description of how bazeldnf is installed and invoked in the course of make rpm-defs

Signed-off-by: cfillekes <cfilleke@redhat.com>

* Update rpm/README.md

document use of  ./hack/build/bazel-docker.sh bash to dig around in the builder container. 

Signed-off-by: cfillekes <cfilleke@redhat.com>

---------

Signed-off-by: cfillekes <cfilleke@redhat.com>
@cfilleke
Copy link
Collaborator Author

Update rpm/README.md with documentation on when make rpm-deps is actually run, and provide a pointer to the issue in project-infra to automate this periodically kubevirt/project-infra#3595

cfilleke added a commit to cfilleke/containerized-data-importer that referenced this issue Aug 26, 2024
additional details for periodic rpm list maintenance
kubevirt#3089

Signed-off-by: cfillekes <cfilleke@redhat.com>
kubevirt-bot pushed a commit that referenced this issue Aug 27, 2024
additional details for periodic rpm list maintenance
#3089

Signed-off-by: cfillekes <cfilleke@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant