Create rpm/README.md #3090
Create rpm/README.md #3090
Conversation
issue kubevirt#3089 It would be helpful for there to be a README.md in the rpm directory instructing maintainers on the configuration of bazeldnf parameters to populate the rpm lists in rpm/BUILD.bazel via the files .bazelrc, repo.yaml and hack/build/rpm-defs.sh, the fact that bazeldnf needs to be invoked through the make target rpm-defs, and also an indication that bazeldnf needs to be installed on the build host in order as it is not present in the builder image. Signed-off-by: cfillekes <cfilleke@redhat.com>
kubevirt-bot
added
the
needs-ok-to-test
|
Hi @cfilleke. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
added
dco-signoff: yes
|
/ok-to-test |
kubevirt-bot
added
ok-to-test
kubevirt-bot
added
the
do-not-merge/release-note-label-needed
|
/retest-required |
Correct description of how bazeldnf is installed and invoked in the course of make rpm-defs Signed-off-by: cfillekes <cfilleke@redhat.com>
document use of ./hack/build/bazel-docker.sh bash to dig around in the builder container. Signed-off-by: cfillekes <cfilleke@redhat.com>
|
/retest-required |
|
Hi, @mhenriks it looks like all this would need is the lgtm tag to merge this? |
kubevirt-bot
added
release-note-none
|
/lgtm |
|
Thanks @cfilleke! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
issue #3089 It would be helpful for there to be a README.md in the rpm directory instructing maintainers on the configuration of bazeldnf parameters to populate the rpm lists in rpm/BUILD.bazel via the files .bazelrc, repo.yaml and hack/build/rpm-defs.sh, the fact that bazeldnf needs to be invoked through the make target rpm-defs, and also an indication that bazeldnf needs to be installed on the build host in order as it is not present in the builder image.
What this PR does / why we need it:
It would be helpful for there to be a README.md in the rpm directory instructing maintainers on the configuration of bazeldnf parameters to populate the rpm lists in rpm/BUILD.bazel via the files .bazelrc, repo.yaml and hack/build/rpm-defs.sh, the fact that bazeldnf needs to be invoked through the make target rpm-defs, and also an indication that bazeldnf needs to be installed on the build host in order as it is not present in the builder image.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3089
Special notes for your reviewer:
note that bazeldnf is now being released for s390x and Power as well as ARM and x86
see https://github.com/rmohr/bazeldnf/releases/tag/v0.5.9-rc2
Release note: