Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release branch presubmits are missing run_before_merge: true #3478

Open
brianmcarey opened this issue Jun 19, 2024 · 5 comments
Open

New release branch presubmits are missing run_before_merge: true #3478

brianmcarey opened this issue Jun 19, 2024 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@brianmcarey
Copy link
Member

This field was added to the main branch presubmit jobs to enable use of the phased plugin - the phased plugin does not target release branches and the run_before_merge field is missing from the recent v1.3 presubmit job config[1].

This issue can cause backport PRs to merge without having the full suite of CI test lanes run successfully[2].

[1] #3477
[2] https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=12132

@brianmcarey
Copy link
Member Author

cc @oshoval @dhiller

@oshoval
Copy link
Contributor

oshoval commented Jun 19, 2024

Thanks

We can either take this PR #3126 - imo it is the best
do those manually upon forking (change to always_run = true), or add the run_before_merge
or upgrade prow utils so they will have the new field in the struct (but for that Bazel did problems)
we can also introduce dummy struct with the new field inline and use it

supporting phased on branches wont help because we do need run_before_merge and to consider branch protection
(unless we develop phased plugin deeper to not miss events and so on)

@dhiller
Copy link
Contributor

dhiller commented Jun 19, 2024

FYI @xpivarc

We need to take that into account next release at the latest!

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2024
@dhiller
Copy link
Contributor

dhiller commented Sep 17, 2024

/remove-lifecycle stale
/lifecycle frozen

@kubevirt-bot kubevirt-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants