Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt,presubmit: enable kubernetes v1.31 lanes to always run #3600

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

Kubernetes v1.31.0 has been released[1] and the k8s-1.31 periodic lanes look very stable[2]. Introduce the k8s-1.31 lanes to always run and required.

Move the kubernetes v1.29 test lanes to phase two and remove the kubernetes v1.28 test lanes.

Also update the compute-serial and compute-migrations lane to v1.31

[1] https://github.com/kubernetes/kubernetes/releases/tag/v1.31.0
[2] https://testgrid.kubernetes.io/kubevirt-periodics

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Signed-off-by: Brian Carey <bcarey@redhat.com>
Signed-off-by: Brian Carey <bcarey@redhat.com>
Signed-off-by: Brian Carey <bcarey@redhat.com>
… to k8s-1.31

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 27, 2024
@brianmcarey
Copy link
Member Author

/rehearse ?

@kubevirt-bot
Copy link
Contributor

Rehearsal is available for the following jobs in this PR:

pull-kubevirt-e2e-k8s-1.31-sig-network
pull-kubevirt-e2e-k8s-1.31-sig-storage
pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
pull-kubevirt-e2e-k8s-1.30-sig-network
pull-kubevirt-e2e-k8s-1.30-sig-compute
pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.30-sig-storage
pull-kubevirt-e2e-k8s-1.31-sig-compute
pull-kubevirt-e2e-k8s-1.31-sig-operator
pull-kubevirt-e2e-k8s-1.30-sig-operator

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@brianmcarey
Copy link
Member Author

/rehearse pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
/rehearse pull-kubevirt-e2e-k8s-1.31-sig-compute-serial

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you @brianmcarey - one question: did you use the tool to do that?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@brianmcarey
Copy link
Member Author

/approve

Thank you @brianmcarey - one question: did you use the tool to do that?

I didn't use the tool as we still have the issue with the tool removing the run_before_merge: true due to the older test-infra dependency - #3478

@kubevirt-bot kubevirt-bot merged commit f0baa0f into kubevirt:main Aug 27, 2024
7 checks passed
@kubevirt-bot
Copy link
Contributor

@brianmcarey: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml
  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

In response to this:

What this PR does / why we need it:

Kubernetes v1.31.0 has been released[1] and the k8s-1.31 periodic lanes look very stable[2]. Introduce the k8s-1.31 lanes to always run and required.

Move the kubernetes v1.29 test lanes to phase two and remove the kubernetes v1.28 test lanes.

Also update the compute-serial and compute-migrations lane to v1.31

[1] https://github.com/kubernetes/kubernetes/releases/tag/v1.31.0
[2] https://testgrid.kubernetes.io/kubevirt-periodics

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

brianmcarey added a commit to brianmcarey/project-infra that referenced this pull request Sep 4, 2024
…1.31

This change was missed in the previous bump PR - kubevirt#3600

Signed-off-by: Brian Carey <bcarey@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Sep 4, 2024
…1.31 (#3622)

This change was missed in the previous bump PR - #3600

Signed-off-by: Brian Carey <bcarey@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants