Enable multiarch builds for pr-creator image

[chandramerla]

What this PR does / why we need it:
This PR updates base image (golang) version and Go version to newer versions and mainly enables multi-arch images for pr-creator.

Multi-arch images for pr-creator are needed as now with #3566 we want to move PR creation part into periodic-kubevirtci-bump-centos-base-s390x. So that after x86 centos images are built, followed by s390x builds and manifest-list, we will create the PR in the s390x machine.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

[kubevirt-bot]

Hi @chandramerla. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[chandramerla]

/test ?

[kubevirt-bot]

@chandramerla: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[brianmcarey]

Can you update the presubmit as well?

project-infra/github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

Line 422 in 0f24021

./publish_image.sh -b pr-creator quay.io kubevirtci

Then I will be able to run rehearsals to test it.

[chandramerla]

Can you update the presubmit as well?

project-infra/github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

Line 422 in 0f24021

./publish_image.sh -b pr-creator quay.io kubevirtci

Then I will be able to run rehearsals to test it.

@brianmcarey I've updated project-infra-presubmits.yaml

[brianmcarey]

/rehearse

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-build-pr-creator-image

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[brianmcarey]

@chandramerla The resource limits will have to removed from the prowjobs as we are doing emulated builds. I can see the rehearsal is running very slowly due to strict CPU limits.

[chandramerla]

@chandramerla The resource limits will have to removed from the prowjobs as we are doing emulated builds. I can see the rehearsal is running very slowly due to strict CPU limits.

I've removed the resource section completely from the spec section, so I believe it falls back to defaults which I assure are higher :)

The last job run failed (unexpected disconnect) during git checkout of test-infra repo. Could it be due to network issues or github rate limits?

• git clone https://github.com/kubernetes/test-infra.git
  Cloning into 'test-infra'...
  error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
  error: 6239 bytes of body are still expected
  fetch-pack: unexpected disconnect while reading sideband packet
  fatal: early EOF
  fatal: fetch-pack: invalid index-pack output
  Error: building at STEP "RUN set -x && git clone https://github.com/kubernetes/test-infra.git && cd ./test-infra && git checkout e4d87dae72dbf1754625cbf112afc535307c1db4 && /usr/local/bin/runner.sh /bin/sh -ce 'go build -o ./robots/pr-creator/pr-creator ./robots/pr-creator/main.go' && mv ./robots/pr-creator/pr-creator /usr/local/bin/ && chmod +x /usr/local/bin/pr-creator && /usr/local/bin/runner.sh /bin/sh -ce 'go clean -cache -modcache' && cd .. && rm -rf ./test-infra": while running runtime: exit status 128
• EXIT_VALUE=128

[chandramerla]

/retest

[kubevirt-bot]

@chandramerla: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[brianmcarey]

/rehearse

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-build-pr-creator-image

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[brianmcarey]

/rehearse

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-build-pr-creator-image

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[chandramerla]

Last run of job rehearsal-build-pr-creator-image failed as arm64 build output path for labels-checker ie., ./bazel-out/aarch64-fastbuild/bin/robots/cmd/labels-checker/labels-checker_/labels-checker
is different from amd64 path ie., ./bazel-out/k8-fastbuild/bin/robots/cmd/labels-checker/labels-checker_/labels-checker

So, Now I've updated bazel based build of labels-checker with go native build and tested it locally and multi-arch build of pr-creator is successful. As bazel is not supported in s390x, I've replaced bazel based build with go native build, there the above problem won't be there anyway as it generates the output in the given path across archs.

Could someone please trigger reharse job again?

[brianmcarey]

/rehearse

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-build-pr-creator-image

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[brianmcarey]

/test all

[brianmcarey]

/test all

[brianmcarey]

Can you please just re-add the memory requests here ? This just ensures that is gets enough RAM on the node.

[chandramerla]

@brianmcarey You mean only memory requests ie.,
resources: requests: memory: "16Gi"

without adding back the cpu requests and memory+cpu limits ?

P.S: As we discussed earlier in DM, I will add -a flag to ./publish_multiarch_image.sh once testing is complete as this is pre-submit job.

[brianmcarey]

@brianmcarey You mean only memory requests ie., resources: requests: memory: "16Gi"

without adding back the cpu requests and memory+cpu limits ?

Yes without the cpu requests and memory+cpu limits - thanks

[brianmcarey]

P.S: As we discussed earlier in DM, I will add -a flag to ./publish_multiarch_image.sh once testing is complete as this is pre-submit job.

I am ok with leaving the presubmit as is for now - this image doesn't get updated that often so doing the full build of the three images in the presubmit should not be too costly.

[chandramerla]

Better I will add -a. That way I can keep the same resource requests 16Gi, than changing to 29Gi, as multi-arch build for all archs needs more resources. Also to be consistent with other image builds in presubmits. WDYT?

[chandramerla]

For now I'm leaving this as is (without -a) and adding 29Gi for memory.

Later before merge I can change - to add -a and keeping only memory request to 16Gi.

[brianmcarey]

/rehearse

[kubevirt-bot]

Rehearsal jobs created for this PR:

rehearsal-build-pr-creator-image

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

[brianmcarey]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brianmcarey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-bot]

@chandramerla: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

• key project-infra-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-postsubmits.yaml
• key project-infra-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

In response to this:

What this PR does / why we need it:
This PR updates base image (golang) version and Go version to newer versions and mainly enables multi-arch images for pr-creator.

Multi-arch images for pr-creator are needed as now with #3566 we want to move PR creation part into periodic-kubevirtci-bump-centos-base-s390x. So that after x86 centos images are built, followed by s390x builds and manifest-list, we will create the PR in the s390x machine.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.