approvers: add commenter that marks stale PRs #3655
Conversation
Adds a periodic job using the commenter to mark PRs that haven't received a review by an approver within a week with the needs/approver-review label. Since that label doesn't exist yet, it is added as well - furthermore the documentation page is updated. Signed-off-by: Daniel Hiller <dhiller@redhat.com>
kubevirt-bot
added
the
dco-signoff: yes
|
/cc @alicefr @iholder101 |
|
/lgtm |
|
/hold This will not work, since the label plugin does allow to manipulate only certain kinds of default labels. I need to add a configuration that allows to add the label, but currently I am not so sure whether the chosen label is the best idea. |
kubevirt-bot
added
the
do-not-merge/hold
Since the initial approach (using the `/needs ...`) is not supported by the label plugin, we use the `/label` command. This requires a configuration in the label plugin section to allow the bot user to set the label on PRs, which we add here. Finally we update the labels.md page with the latest changes. Signed-off-by: Daniel Hiller <dhiller@redhat.com>
|
/unhold Updates: changed the label to |
kubevirt-bot
removed
the
do-not-merge/hold
|
/lgtm |
| is:pr | ||
| label:lgtm | ||
| -label:approved | ||
| -label:do-not-merge/work-in-progress |
There was a problem hiding this comment.
Do we want to also add -label:do-not-merge/hold?
There was a problem hiding this comment.
I think that there might be cases where we don't want to exclude PRs that have a hold - i.e. this PR would still require reviewer attention, while it has an LGTM: kubevirt/community#297
(might be a special case though)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@dhiller: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Adds a periodic job that will apply the label
needs-approver-reviewto PRs that haven't received a review by an approver within a week.Since that label doesn't exist yet, it is added as well - furthermore the documentation page is updated.
Finally a configuration to allow the bot user to apply the label is added in the label plugin config section.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: