Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move priority/backlog to global label definition #3661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anishbista60
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3654

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 19, 2024
@kubevirt-bot
Copy link
Contributor

Hi @anishbista60. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anishbista60
Copy link
Contributor Author

@dhiller Request for review ?

@dhiller
Copy link
Contributor

dhiller commented Sep 20, 2024

@dhiller Request for review ?

You mean

/cc @dhiller

@dhiller
Copy link
Contributor

dhiller commented Sep 20, 2024

@anishbista60 the file you have changed is auto-generated, therefore changing it will have no effect on the label definitions.

Editing our GitHub labels is done by editing the labels.yaml - similarly to adding a label 2 - thus we need to move the label definition of priority/backlog 3 to somewhere below the yaml path .default.labels (best would be to place it adjacent to the other priority label.

Afterwards you need to run make update-labels, which will update the labels.md file.

Please do all this in one commit, so we have the changes grouped together nicely.

Thank you for looking into this!

@dhiller
Copy link
Contributor

dhiller commented Sep 20, 2024

@anishbista60 I have update the issue description also - hope the task is more clear now. Sorry for the confusion.

@anishbista60
Copy link
Contributor Author

@dhiller Thank you

Signed-off-by: Anish Bista <anishbista053@gmail.com>
@anishbista60
Copy link
Contributor Author

anishbista60 commented Sep 20, 2024

@anishbista60 the file you have changed is auto-generated, therefore changing it will have no effect on the label definitions.

Editing our GitHub labels is done by editing the labels.yaml - similarly to adding a label 2 - thus we need to move the label definition of priority/backlog 3 to somewhere below the yaml path .default.labels (best would be to place it adjacent to the other priority label.

Afterwards you need to run make update-labels, which will update the labels.md file.

Please do all this in one commit, so we have the changes grouped together nicely.

Thank you for looking into this!

Thanks for great explanation, made it so easy .
Now, every thing done. Please check.

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2024
@kubevirt-bot
Copy link
Contributor

@anishbista60: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-project-infra-prow-deploy-test 22c93f1 link true /test pull-project-infra-prow-deploy-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anishbista60
Copy link
Contributor Author

@dhiller pull-project-infra-prow-deploy-test failing

@anishbista60
Copy link
Contributor Author

@brianmcarey could you please look into ? unable to get the exact reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move priority/backlog to global label definition
3 participants