-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move priority/backlog to global label definition #3661
base: main
Are you sure you want to change the base?
Conversation
Hi @anishbista60. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dhiller Request for review ? |
@anishbista60 the file you have changed is auto-generated, therefore changing it will have no effect on the label definitions. Editing our GitHub labels is done by editing the labels.yaml - similarly to adding a label 2 - thus we need to move the label definition of Afterwards you need to run Please do all this in one commit, so we have the changes grouped together nicely. Thank you for looking into this! |
@anishbista60 I have update the issue description also - hope the task is more clear now. Sorry for the confusion. |
@dhiller Thank you |
Signed-off-by: Anish Bista <anishbista053@gmail.com>
Thanks for great explanation, made it so easy . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@anishbista60: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@dhiller |
@brianmcarey could you please look into ? unable to get the exact reason |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3654
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: