Skip to content

update node-labeller docs to include machine types labels #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dasionov
Copy link

What this PR does / why we need it:
minor updates to the node-labeller docs in regards to the machine type labels that is being used since kubevirt/kubevirt#13690

Release note:

update node-labeller docs to include machine type labels

Signed-off-by: Daniel Sionov <dsionov@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 24, 2025
@kubevirt-bot kubevirt-bot requested a review from phoracek April 24, 2025 23:24
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign iholder101 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dasionov
Copy link
Author

/cc @Barakmor1

is this enough? or should i elaborate more about the fact the node-labeller is a must since the machine-type is automatically included in the node-selector

@kubevirt-bot kubevirt-bot requested a review from Barakmor1 April 24, 2025 23:25
@Barakmor1
Copy link
Member

/lgtm

Thank you!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@kubevirt-bot
Copy link
Contributor

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants