Skip to content

Document current limitation of dedicatedIOThread on scsi disks #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alicefr
Copy link
Member

@alicefr alicefr commented May 9, 2025

Document current limitation when dedicatedIOThreads field is specified on scsi devices. This behavior has been introduced by kubevirt/kubevirt#11219

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 9, 2025
@alicefr
Copy link
Member Author

alicefr commented May 9, 2025

/cc @awels @xpivarc

@kubevirt-bot kubevirt-bot requested review from awels and ShellyKa13 May 9, 2025 13:13
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alicefr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Alice Frosi <afrosi@redhat.com>
@alicefr alicefr force-pushed the doc-limitation-iothread-scsi branch from 4518162 to 55c042f Compare May 9, 2025 13:14
`IOThreads are not supported for disks on a %s bus`. The reason for this limitation
consists that KubeVirt supports a single scsi controller for all the disks using the
`scsi` bus, and QEMU does not support assigning each IOThreads to each scsi disks,
instead they can only be assigned at the controller level.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any mechanism for setting it at the controller level available right now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we refuse at the webhook level when we set the dedicatedIOThread, no. The current code could assign a single iothread, like the emulatorThread. However, libvirt does support multiple iothreads for the controller, so we could enhance this mechanism. However, I do belive that this requires some API changes since it doesn't apply on a single disk but at the entire controller level.

@alicefr
Copy link
Member Author

alicefr commented May 9, 2025

/cc @alromeros

@kubevirt-bot kubevirt-bot requested a review from alromeros May 9, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants