Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky unit test #367

Merged
merged 1 commit into from
Oct 24, 2023
Merged

test: fix flaky unit test #367

merged 1 commit into from
Oct 24, 2023

Conversation

flavio
Copy link
Member

@flavio flavio commented Oct 24, 2023

Rewrote a unit test to avoid random failures. cargo test runs multiple tests in parallel, with a randomized order.

Under some circumstances, multiple wapc policies were defined at the same time, causing the hard coded expected values to fail.

The test has been rewritten to use different assertion criteria.

Rewrote a unit test to avoid random failures. `cargo test` runs multiple
tests in parallel, with a randomized order.

Under some circumstances, multiple wapc policies were defined at the
same time, causing the hard coded expected values to fail.

The test has been rewritten to use different assertion criteria.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio requested a review from a team as a code owner October 24, 2023 15:40
@flavio flavio merged commit 086640e into kubewarden:main Oct 24, 2023
@flavio flavio deleted the fix-flaky-test branch October 24, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants