Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: adding support to cgroup level io.weight setting
Signed-off-by: Jianyu Sun <sjycsfldf@gmail.com> Signed-off-by: Robin Lu <robin.lu@bytedance.com>
- Loading branch information
1 parent
6ea1052
commit c2f34c3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,5 @@ const ( | |
|
|
||
| controlKnobKeyIOWeight = "io_weight" | ||
| cgroupIOWeightName = "io.weight" | ||
| defaultDevID = "default" | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| //go:build linux | ||
| // +build linux | ||
|
|
||
| /* | ||
| Copyright 2022 The Katalyst Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package ioweight | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| v1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| coreconfig "github.com/kubewharf/katalyst-core/pkg/config" | ||
| "github.com/kubewharf/katalyst-core/pkg/config/agent" | ||
| configagent "github.com/kubewharf/katalyst-core/pkg/config/agent" | ||
| dynamicconfig "github.com/kubewharf/katalyst-core/pkg/config/agent/dynamic" | ||
| "github.com/kubewharf/katalyst-core/pkg/config/agent/qrm" | ||
| "github.com/kubewharf/katalyst-core/pkg/metaserver" | ||
| metaagent "github.com/kubewharf/katalyst-core/pkg/metaserver/agent" | ||
| "github.com/kubewharf/katalyst-core/pkg/metaserver/agent/metric" | ||
| "github.com/kubewharf/katalyst-core/pkg/metaserver/agent/pod" | ||
| "github.com/kubewharf/katalyst-core/pkg/metrics" | ||
| "github.com/kubewharf/katalyst-core/pkg/util/machine" | ||
| ) | ||
|
|
||
| func makeMetaServer() (*metaserver.MetaServer, error) { | ||
| server := &metaserver.MetaServer{ | ||
| MetaAgent: &metaagent.MetaAgent{}, | ||
| } | ||
|
|
||
| cpuTopology, err := machine.GenerateDummyCPUTopology(16, 1, 2) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| server.KatalystMachineInfo = &machine.KatalystMachineInfo{ | ||
| CPUTopology: cpuTopology, | ||
| } | ||
| server.MetricsFetcher = metric.NewFakeMetricsFetcher(metrics.DummyMetrics{}) | ||
| return server, nil | ||
| } | ||
|
|
||
| func TestIOWeightTaskFunc(t *testing.T) { | ||
| t.Parallel() | ||
| IOWeightTaskFunc(&coreconfig.Configuration{ | ||
| AgentConfiguration: &agent.AgentConfiguration{ | ||
| StaticAgentConfiguration: &configagent.StaticAgentConfiguration{ | ||
| QRMPluginsConfiguration: &qrm.QRMPluginsConfiguration{ | ||
| IOQRMPluginConfig: &qrm.IOQRMPluginConfig{ | ||
| IOWeightOption: qrm.IOWeightOption{ | ||
| EnableSettingIOWeight: false, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, nil, &dynamicconfig.DynamicAgentConfiguration{}, nil, nil) | ||
|
|
||
| IOWeightTaskFunc(&coreconfig.Configuration{ | ||
| AgentConfiguration: &agent.AgentConfiguration{ | ||
| StaticAgentConfiguration: &configagent.StaticAgentConfiguration{ | ||
| QRMPluginsConfiguration: &qrm.QRMPluginsConfiguration{ | ||
| IOQRMPluginConfig: &qrm.IOQRMPluginConfig{ | ||
| IOWeightOption: qrm.IOWeightOption{ | ||
| EnableSettingIOWeight: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, nil, &dynamicconfig.DynamicAgentConfiguration{}, metrics.DummyMetrics{}, nil) | ||
|
|
||
| metaServer, err := makeMetaServer() | ||
| assert.NoError(t, err) | ||
| metaServer.PodFetcher = &pod.PodFetcherStub{PodList: []*v1.Pod{}} | ||
|
|
||
| IOWeightTaskFunc(&coreconfig.Configuration{ | ||
| AgentConfiguration: &agent.AgentConfiguration{ | ||
| StaticAgentConfiguration: &configagent.StaticAgentConfiguration{ | ||
| QRMPluginsConfiguration: &qrm.QRMPluginsConfiguration{ | ||
| IOQRMPluginConfig: &qrm.IOQRMPluginConfig{ | ||
| IOWeightOption: qrm.IOWeightOption{ | ||
| EnableSettingIOWeight: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, nil, &dynamicconfig.DynamicAgentConfiguration{}, metrics.DummyMetrics{}, metaServer) | ||
|
|
||
| IOWeightTaskFunc(&coreconfig.Configuration{ | ||
| AgentConfiguration: &agent.AgentConfiguration{ | ||
| StaticAgentConfiguration: &configagent.StaticAgentConfiguration{ | ||
| QRMPluginsConfiguration: &qrm.QRMPluginsConfiguration{ | ||
| IOQRMPluginConfig: &qrm.IOQRMPluginConfig{ | ||
| IOWeightOption: qrm.IOWeightOption{ | ||
| EnableSettingIOWeight: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, metrics.DummyMetrics{}, &dynamicconfig.DynamicAgentConfiguration{}, metrics.DummyMetrics{}, metaServer) | ||
|
|
||
| normalPod := &v1.Pod{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| UID: "normalPod", | ||
| Name: "normalPod", | ||
| }, | ||
| Spec: v1.PodSpec{ | ||
| Containers: []v1.Container{ | ||
| { | ||
| Name: "c", | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| metaServer.PodFetcher = &pod.PodFetcherStub{PodList: []*v1.Pod{normalPod}} | ||
|
|
||
| IOWeightTaskFunc(&coreconfig.Configuration{ | ||
| AgentConfiguration: &agent.AgentConfiguration{ | ||
| StaticAgentConfiguration: &configagent.StaticAgentConfiguration{ | ||
| QRMPluginsConfiguration: &qrm.QRMPluginsConfiguration{ | ||
| IOQRMPluginConfig: &qrm.IOQRMPluginConfig{ | ||
| IOWeightOption: qrm.IOWeightOption{ | ||
| EnableSettingIOWeight: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, metrics.DummyMetrics{}, &dynamicconfig.DynamicAgentConfiguration{}, metrics.DummyMetrics{}, metaServer) | ||
|
|
||
| IOWeightTaskFunc(&coreconfig.Configuration{ | ||
| AgentConfiguration: &agent.AgentConfiguration{ | ||
| StaticAgentConfiguration: &configagent.StaticAgentConfiguration{ | ||
| QRMPluginsConfiguration: &qrm.QRMPluginsConfiguration{ | ||
| IOQRMPluginConfig: &qrm.IOQRMPluginConfig{ | ||
| IOWeightOption: qrm.IOWeightOption{ | ||
| EnableSettingIOWeight: true, | ||
| IOWeightQoSLevelConfigFile: "fake", | ||
| IOWeightCgroupLevelConfigFile: "fake", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, metrics.DummyMetrics{}, &dynamicconfig.DynamicAgentConfiguration{}, metrics.DummyMetrics{}, metaServer) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters