Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eviction): add enhanced numa-level memory pressure eviction plugin #420

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

LuyaoZhong
Copy link
Contributor

@LuyaoZhong LuyaoZhong commented Dec 22, 2023

Add enhanced numa-level memory pressure eviction plugin to replace numa-level eviction and system-level eviction. Enhanced numa-level memory pressure plugin provides a new approach to detect numa pressure, which could help to predict whether it could be recovered by system reclaim mechanism. Do evict when detecting it's hard to recover and Do Not evict when detecting it's easy to recover.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: Patch coverage is 73.33333% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 54.96%. Comparing base (5e7887c) to head (ccca804).
Report is 26 commits behind head on main.

Files Patch % Lines
...ionmanager/plugin/memory/enhanced_numa_pressure.go 75.26% 37 Missing and 10 partials ⚠️
...amic/adminqos/eviction/memory_pressure_eviction.go 50.00% 4 Missing ⚠️
pkg/util/general/deepcopy.go 66.66% 2 Missing and 1 partial ⚠️
pkg/agent/evictionmanager/plugin/memory/helper.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   54.91%   54.96%   +0.04%     
==========================================
  Files         503      514      +11     
  Lines       54789    56975    +2186     
==========================================
+ Hits        30088    31316    +1228     
- Misses      21455    22316     +861     
- Partials     3246     3343      +97     
Flag Coverage Δ
unittest 54.96% <73.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuyaoZhong LuyaoZhong added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Dec 26, 2023
@LuyaoZhong LuyaoZhong marked this pull request as draft January 29, 2024 12:35
@LuyaoZhong LuyaoZhong changed the title enhancement(eviction): refine memory pressure eviction feat(eviction): add enhanced numa-level memory pressure eviction Jan 29, 2024
@LuyaoZhong LuyaoZhong changed the title feat(eviction): add enhanced numa-level memory pressure eviction feat(eviction): add enhanced numa-level memory pressure eviction plugin Jan 29, 2024
@LuyaoZhong LuyaoZhong force-pushed the memory_pressure_eviction branch 4 times, most recently from 996bd37 to 72ba614 Compare February 1, 2024 16:28
predictNumaPressureStatMap[numaID] += podNumaTotal
}
}
getPodPermutations := func(podList []*v1.Pod) [][]*v1.Pod {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when podList get larger, this function will be costly, is it really necessary?

1. prioritize evicting the pod for which stats were found
2. support minimun interval for enhanced numa pressure eviction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit of NumaStatsV1 is page, while the unit of NumaStatsV2 is byte, so there is no need to modify it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants