-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eviction): add enhanced numa-level memory pressure eviction plugin #420
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 54.91% 54.96% +0.04%
==========================================
Files 503 514 +11
Lines 54789 56975 +2186
==========================================
+ Hits 30088 31316 +1228
- Misses 21455 22316 +861
- Partials 3246 3343 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b4eddb6
to
5ac9946
Compare
5ac9946
to
99c9ec3
Compare
996bd37
to
72ba614
Compare
72ba614
to
4e29f0e
Compare
predictNumaPressureStatMap[numaID] += podNumaTotal | ||
} | ||
} | ||
getPodPermutations := func(podList []*v1.Pod) [][]*v1.Pod { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when podList
get larger, this function will be costly, is it really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit of NumaStatsV1 is page, while the unit of NumaStatsV2 is byte, so there is no need to modify it here.
Add enhanced numa-level memory pressure eviction plugin to replace numa-level eviction and system-level eviction. Enhanced numa-level memory pressure plugin provides a new approach to detect numa pressure, which could help to predict whether it could be recovered by system reclaim mechanism. Do evict when detecting it's hard to recover and Do Not evict when detecting it's easy to recover.