-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(overcommit): add realtime overcommit advisor plugin #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangZzzhe
requested review from
caohe,
luomingmeng,
csfldf,
sun-yuliang and
waynepeking348
as code owners
February 7, 2024 11:52
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
from
February 7, 2024 12:04
60ff01e
to
ac84133
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 55.67% 55.78% +0.11%
==========================================
Files 552 524 -28
Lines 59419 48534 -10885
==========================================
- Hits 33083 27077 -6006
+ Misses 22899 18025 -4874
+ Partials 3437 3432 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WangZzzhe
added
enhancement
New feature or request
workflow/need-review
review: test succeeded, need to review
labels
Feb 7, 2024
3 tasks
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
from
March 15, 2024 11:09
ac84133
to
4bb6da1
Compare
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
2 times, most recently
from
March 15, 2024 11:47
5e30800
to
f102e73
Compare
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
2 times, most recently
from
April 10, 2024 02:32
c784dd7
to
aca204b
Compare
caohe
previously approved these changes
Apr 10, 2024
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
3 times, most recently
from
April 15, 2024 03:45
d3c570a
to
b777c62
Compare
caohe
previously approved these changes
Apr 15, 2024
luomingmeng
reviewed
Apr 16, 2024
pkg/agent/sysadvisor/plugin/overcommitmentaware/reporter/reporter.go
Outdated
Show resolved
Hide resolved
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
from
April 16, 2024 04:11
91d423d
to
75618c2
Compare
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
2 times, most recently
from
April 17, 2024 11:30
6441f1a
to
992b136
Compare
WangZzzhe
force-pushed
the
dev/overcommit-bindcpu
branch
from
April 23, 2024 06:52
992b136
to
88bd3ae
Compare
caohe
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
katalyst-agent:
katalyst-controller:
katalyst-webhook:
katalyst-scheduler:
PR in katalyst-api: kubewharf/katalyst-api#75 go.mod should be updated after api PR merged