feat: adding support to io.cost setting #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 55.67% 55.53% -0.14%
==========================================
Files 552 554 +2
Lines 59419 59751 +332
==========================================
+ Hits 33083 33185 +102
- Misses 22899 23130 +231
+ Partials 3437 3436 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lubinszARM
force-pushed
the
pr_iocost_setting
branch
2 times, most recently
from
c711878
to
068d2b0
Compare
lubinszARM
force-pushed
the
pr_iocost_setting
branch
6 times, most recently
from
219ab80
to
ee7a488
Compare
lubinszARM
force-pushed
the
pr_iocost_setting
branch
from
6785ce9
to
8669e74
Compare
lubinszARM
force-pushed
the
pr_iocost_setting
branch
3 times, most recently
from
403a235
to
61fed04
Compare
lubinszARM
force-pushed
the
pr_iocost_setting
branch
11 times, most recently
from
671e0e9
to
e4c0f72
Compare
Signed-off-by: Jianyu Sun <sunjianyu@bytedance.com> Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Signed-off-by: Robin Lu <robin.lu@bytedance.com>
for now, only HDD was supported. Signed-off-by: Robin Lu <robin.lu@bytedance.com>
default io.cost.model applied to HDD disks Signed-off-by: Robin Lu <robin.lu@bytedance.com>
lubinszARM
force-pushed
the
pr_iocost_setting
branch
from
e4c0f72
to
48ad87d
Compare
csfldf
approved these changes
Apr 9, 2024
waynepeking348
pushed a commit
that referenced
this pull request
Apr 12, 2024
* feat: adding support to io.cost setting Signed-off-by: Jianyu Sun <sunjianyu@bytedance.com> Signed-off-by: Robin Lu <robin.lu@bytedance.com> * feat(io.cost): adding rollback method Signed-off-by: Robin Lu <robin.lu@bytedance.com> * iocost: using default io.cost.qos for now, only HDD was supported. Signed-off-by: Robin Lu <robin.lu@bytedance.com> * iocost: using default io.cost.model default io.cost.model applied to HDD disks Signed-off-by: Robin Lu <robin.lu@bytedance.com> --------- Signed-off-by: Jianyu Sun <sunjianyu@bytedance.com> Signed-off-by: Robin Lu <robin.lu@bytedance.com>
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
* feat: adding support to io.cost setting Signed-off-by: Jianyu Sun <sunjianyu@bytedance.com> Signed-off-by: Robin Lu <robin.lu@bytedance.com> * feat(io.cost): adding rollback method Signed-off-by: Robin Lu <robin.lu@bytedance.com> * iocost: using default io.cost.qos for now, only HDD was supported. Signed-off-by: Robin Lu <robin.lu@bytedance.com> * iocost: using default io.cost.model default io.cost.model applied to HDD disks Signed-off-by: Robin Lu <robin.lu@bytedance.com> --------- Signed-off-by: Jianyu Sun <sunjianyu@bytedance.com> Signed-off-by: Robin Lu <robin.lu@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
This patch provied the feature of io.cost setting.
Which issue(s) this PR fixes:
In production area, some critical services and online pods were affected by busy io.
This patch provieded the io qos feature
Special notes for your reviewer:
None