-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spd support cnc cache #542
Merged
waynepeking348
merged 5 commits into
kubewharf:main
from
luomingmeng:dev/spd-support-cnc-cache
Apr 17, 2024
Merged
spd support cnc cache #542
waynepeking348
merged 5 commits into
kubewharf:main
from
luomingmeng:dev/spd-support-cnc-cache
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
force-pushed
the
dev/spd-support-cnc-cache
branch
2 times, most recently
from
April 10, 2024 09:24
9d0db0b
to
cd34065
Compare
luomingmeng
force-pushed
the
dev/spd-support-cnc-cache
branch
9 times, most recently
from
April 11, 2024 07:07
d996963
to
0bbe787
Compare
luomingmeng
force-pushed
the
dev/spd-support-cnc-cache
branch
7 times, most recently
from
April 11, 2024 12:15
d76e3dc
to
458a629
Compare
luomingmeng
added
the
workflow/need-review
review: test succeeded, need to review
label
Apr 11, 2024
luomingmeng
force-pushed
the
dev/spd-support-cnc-cache
branch
4 times, most recently
from
April 15, 2024 02:27
c720d5b
to
9b27a72
Compare
luomingmeng
force-pushed
the
dev/spd-support-cnc-cache
branch
from
April 16, 2024 06:36
1c53c00
to
933b194
Compare
waynepeking348
added
the
workflow/merge-ready
merge-ready: code is ready and can be merged
label
Apr 16, 2024
waynepeking348
force-pushed
the
dev/spd-support-cnc-cache
branch
6 times, most recently
from
April 16, 2024 10:57
9be3cf0
to
e3601d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
- Coverage 55.67% 55.59% -0.09%
==========================================
Files 552 512 -40
Lines 59419 47448 -11971
==========================================
- Hits 33083 26378 -6705
+ Misses 22899 17731 -5168
+ Partials 3437 3339 -98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
waynepeking348
force-pushed
the
dev/spd-support-cnc-cache
branch
15 times, most recently
from
April 17, 2024 03:01
5d6c7ae
to
76fcb1f
Compare
waynepeking348
force-pushed
the
dev/spd-support-cnc-cache
branch
from
April 17, 2024 03:30
76fcb1f
to
208c578
Compare
luomingmeng
force-pushed
the
dev/spd-support-cnc-cache
branch
from
April 17, 2024 03:57
4ecd416
to
3129c92
Compare
waynepeking348
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
workflow/merge-ready
merge-ready: code is ready and can be merged
workflow/need-review
review: test succeeded, need to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
To minimize high query-per-second (QPS) rates from agents to the API server, we implement a Custom Node Config (CNC) to store Service Profile Descriptor (SPD) information needed by the node, acting as an SPD cache. Agents periodically fetch the CNC, and will only attempt to update the local SPD cache from the API server if there's a mismatch between the hash of the local cache's SPD and the SPD information in the CNC.