Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spd support cnc cache #542

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Features

What this PR does / why we need it:

To minimize high query-per-second (QPS) rates from agents to the API server, we implement a Custom Node Config (CNC) to store Service Profile Descriptor (SPD) information needed by the node, acting as an SPD cache. Agents periodically fetch the CNC, and will only attempt to update the local SPD cache from the API server if there's a mismatch between the hash of the local cache's SPD and the SPD information in the CNC.

@luomingmeng luomingmeng marked this pull request as ready for review April 10, 2024 08:50
@luomingmeng luomingmeng force-pushed the dev/spd-support-cnc-cache branch 2 times, most recently from 9d0db0b to cd34065 Compare April 10, 2024 09:24
@luomingmeng luomingmeng self-assigned this Apr 10, 2024
@luomingmeng luomingmeng added the enhancement New feature or request label Apr 10, 2024
@luomingmeng luomingmeng force-pushed the dev/spd-support-cnc-cache branch 9 times, most recently from d996963 to 0bbe787 Compare April 11, 2024 07:07
@luomingmeng luomingmeng force-pushed the dev/spd-support-cnc-cache branch 7 times, most recently from d76e3dc to 458a629 Compare April 11, 2024 12:15
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Apr 11, 2024
@luomingmeng luomingmeng force-pushed the dev/spd-support-cnc-cache branch 4 times, most recently from c720d5b to 9b27a72 Compare April 15, 2024 02:27
@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Apr 16, 2024
@waynepeking348 waynepeking348 force-pushed the dev/spd-support-cnc-cache branch 6 times, most recently from 9be3cf0 to e3601d6 Compare April 16, 2024 10:57
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 62.81690% with 132 lines in your changes are missing coverage. Please review.

Project coverage is 55.59%. Comparing base (b122f7b) to head (3129c92).
Report is 23 commits behind head on main.

Files Patch % Lines
pkg/controller/spd/cnc.go 66.23% 50 Missing and 28 partials ⚠️
pkg/util/spd.go 32.25% 16 Missing and 5 partials ⚠️
pkg/util/native/pod_finder.go 59.09% 5 Missing and 4 partials ⚠️
pkg/controller/spd/spd.go 70.37% 4 Missing and 4 partials ⚠️
pkg/metaserver/spd/cache.go 46.15% 4 Missing and 3 partials ⚠️
cmd/katalyst-controller/app/options/spd.go 50.00% 2 Missing ⚠️
pkg/controller/kcc/cnc.go 77.77% 1 Missing and 1 partial ⚠️
pkg/metaserver/spd/fetcher.go 33.33% 1 Missing and 1 partial ⚠️
...lifecycle/agent-healthz/handler/handler_generic.go 0.00% 1 Missing ⚠️
...ller/lifecycle/agent-healthz/healthz_controller.go 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   55.67%   55.59%   -0.09%     
==========================================
  Files         552      512      -40     
  Lines       59419    47448   -11971     
==========================================
- Hits        33083    26378    -6705     
+ Misses      22899    17731    -5168     
+ Partials     3437     3339      -98     
Flag Coverage Δ
unittest 55.59% <62.81%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 force-pushed the dev/spd-support-cnc-cache branch 15 times, most recently from 5d6c7ae to 76fcb1f Compare April 17, 2024 03:01
@waynepeking348 waynepeking348 merged commit bd179d0 into kubewharf:main Apr 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants