Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TransparentMemoryOffloading plugin to trigger memory offloading #549

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

cheney-lin
Copy link
Member

@cheney-lin cheney-lin commented Apr 15, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

This feature provides ability to trigger memory offload to save memory without performance downgrade, saved memory could be used for deploy more reclaimed_cores workloads to raise CPU utilization.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin changed the title feat: Add TransparentMemoryOffloading plugin to trigger memory offloa… feat: Add TransparentMemoryOffloading plugin to trigger memory offloading Apr 15, 2024
@cheney-lin cheney-lin force-pushed the dev/tmo branch 5 times, most recently from c16fa8b to 2da190f Compare April 17, 2024 06:05
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 55.51537% with 246 lines in your changes are missing coverage. Please review.

Project coverage is 55.94%. Comparing base (88bd3ae) to head (7a1e3f1).
Report is 23 commits behind head on main.

Files Patch % Lines
...saware/resource/memory/plugin/memory_offloading.go 66.33% 70 Missing and 33 partials ⚠️
pkg/util/cgroup/manager/cgroup.go 32.50% 41 Missing and 13 partials ⚠️
...ins/memory/dynamicpolicy/policy_advisor_handler.go 24.39% 30 Missing and 1 partial ⚠️
...tions/dynamic/tmo/tmodefault/tmo_default_config.go 52.63% 18 Missing ⚠️
.../agent/metric/provisioner/malachite/provisioner.go 56.00% 11 Missing ⚠️
...sadvisor/plugin/qosaware/resource/helper/helper.go 36.36% 7 Missing ⚠️
pkg/util/general/common.go 0.00% 5 Missing ⚠️
pkg/util/metric/store.go 66.66% 5 Missing ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 62.50% 1 Missing and 2 partials ⚠️
...katalyst-agent/app/options/dynamic/tmo/tmo_base.go 77.77% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   55.78%   55.94%   +0.15%     
==========================================
  Files         524      532       +8     
  Lines       48534    49593    +1059     
==========================================
+ Hits        27077    27744     +667     
- Misses      18025    18316     +291     
- Partials     3432     3533     +101     
Flag Coverage Δ
unittest 55.94% <55.51%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Apr 17, 2024
@cheney-lin cheney-lin force-pushed the dev/tmo branch 5 times, most recently from 4b123a4 to 9d7a508 Compare April 17, 2024 16:10
@cheney-lin cheney-lin force-pushed the dev/tmo branch 8 times, most recently from c54c6e1 to 11e81aa Compare April 22, 2024 13:15
@cheney-lin cheney-lin force-pushed the dev/tmo branch 2 times, most recently from fabbb99 to 5dec9e0 Compare April 22, 2024 14:11
@cheney-lin cheney-lin requested a review from csfldf April 22, 2024 14:24
csfldf
csfldf previously approved these changes Apr 23, 2024
LuyaoZhong and others added 4 commits April 29, 2024 11:27
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@nightmeng nightmeng merged commit 8475c45 into kubewharf:main Apr 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants