Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): support shared_cores with numa_binding #556

Merged
merged 8 commits into from
Jun 12, 2024

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Apr 22, 2024

feat(qrm): support shared_cores with numa_binding

@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Apr 22, 2024
@csfldf csfldf self-assigned this Apr 22, 2024
@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch from 87815b3 to 9eb1ef1 Compare April 22, 2024 12:20
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 62.43243% with 278 lines in your changes missing coverage. Please review.

Project coverage is 56.25%. Comparing base (2a9f961) to head (22693d7).
Report is 1 commits behind head on main.

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 60.57% 81 Missing and 29 partials ⚠️
...agent/qrm-plugins/cpu/dynamicpolicy/state/state.go 56.36% 28 Missing and 20 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 71.20% 27 Missing and 9 partials ⚠️
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 77.39% 15 Missing and 11 partials ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 44.82% 13 Missing and 3 partials ⚠️
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/helper.go 48.14% 12 Missing and 2 partials ⚠️
...u/dynamicpolicy/validator/validator_cpu_advisor.go 30.00% 6 Missing and 1 partial ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 33.33% 5 Missing and 1 partial ⚠️
pkg/util/machine/util.go 0.00% 6 Missing ⚠️
cmd/katalyst-agent/app/options/qrm/cpu_plugin.go 42.85% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   56.34%   56.25%   -0.09%     
==========================================
  Files         543      543              
  Lines       50373    50958     +585     
==========================================
+ Hits        28381    28667     +286     
- Misses      18391    18621     +230     
- Partials     3601     3670      +69     
Flag Coverage Δ
unittest 56.25% <62.43%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch from 9eb1ef1 to 9cb0394 Compare April 24, 2024 07:14
@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch 3 times, most recently from 2c36e29 to 29d67e2 Compare May 6, 2024 12:38
waynepeking348
waynepeking348 previously approved these changes May 7, 2024
@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch 2 times, most recently from 4d4e66d to e980b99 Compare May 8, 2024 09:02
@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch 3 times, most recently from e3847e8 to ed23f14 Compare June 6, 2024 06:36
@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch from 9f89ef6 to 407cabd Compare June 11, 2024 09:06
@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch from 407cabd to 05137cc Compare June 11, 2024 09:34
@csfldf csfldf force-pushed the dev/shared_cores_numa_binding branch from 420c1c0 to 22693d7 Compare June 11, 2024 13:10
@csfldf csfldf merged commit 3a0e668 into kubewharf:main Jun 12, 2024
11 checks passed
@chzhj
Copy link

chzhj commented Jul 19, 2024

dedicated_cores with numa binding的pod,在计算hint的时候,允许调度到shared_cores numabinding 的numa node上么

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants