Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make kernel allocate zram memory at allowed NUMAs of workload process #685

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

cheney-lin
Copy link
Member

@cheney-lin cheney-lin commented Aug 28, 2024

refactor: make kernel allocate zram memory at allowed NUMAs of workload process

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin force-pushed the dev/tmo_reclaim_bind_numa branch 2 times, most recently from 69fce22 to d191666 Compare August 29, 2024 03:08
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 63.04348% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.13%. Comparing base (f975841) to head (3968272).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/cgroup/manager/cgroup.go 74.35% 5 Missing and 5 partials ⚠️
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
- Coverage   57.24%   57.13%   -0.11%     
==========================================
  Files         568      568              
  Lines       54757    54800      +43     
==========================================
- Hits        31343    31312      -31     
- Misses      19488    19575      +87     
+ Partials     3926     3913      -13     
Flag Coverage Δ
unittest 57.13% <63.04%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin self-assigned this Sep 2, 2024
…ad process

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin changed the title refactor: make kernel allocate zram memory at NUMAs allowed for busin… refactor: make kernel allocate zram memory at allowed NUMAs of workload process Sep 12, 2024
@cheney-lin cheney-lin force-pushed the dev/tmo_reclaim_bind_numa branch 3 times, most recently from da71043 to 25d4f31 Compare September 12, 2024 13:19
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Sep 12, 2024
@xu282934741 xu282934741 merged commit 56959bd into kubewharf:main Oct 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants