Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): empty cpuset.mems will lead to failure of tmo #721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 55.86%. Comparing base (19aa317) to head (30f7cc6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/cgroup/manager/cgroup.go 56.75% 11 Missing and 5 partials ⚠️
pkg/util/cgroup/manager/v1/fs_linux.go 20.00% 6 Missing and 2 partials ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 40.00% 4 Missing and 2 partials ⚠️
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
- Coverage   56.04%   55.86%   -0.18%     
==========================================
  Files         594      594              
  Lines       67830    67882      +52     
==========================================
- Hits        38012    37924      -88     
- Misses      25771    25928     +157     
+ Partials     4047     4030      -17     
Flag Coverage Δ
unittest 55.86% <50.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin force-pushed the fix/tmo branch 18 times, most recently from 43d9631 to 587e054 Compare November 16, 2024 14:47
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin self-assigned this Nov 17, 2024
@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant