-
-
Notifications
You must be signed in to change notification settings - Fork 1
Improved vscode user-defined scope settings #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import * as vscode from "vscode"; | ||
|
|
||
| export const CONFIG_SECTION = "quickCommandButtons"; | ||
|
|
||
| export const CONFIG_KEYS = { | ||
| BUTTONS: "buttons", | ||
| CONFIGURATION_TARGET: "configurationTarget", | ||
| REFRESH_BUTTON: "refreshButton", | ||
| } as const; | ||
|
|
||
| export const CONFIGURATION_TARGETS = { | ||
| WORKSPACE: "workspace", | ||
| GLOBAL: "global", | ||
| } as const; | ||
|
|
||
| export const VS_CODE_CONFIGURATION_TARGETS = { | ||
| [CONFIGURATION_TARGETS.WORKSPACE]: vscode.ConfigurationTarget.Workspace, | ||
| [CONFIGURATION_TARGETS.GLOBAL]: vscode.ConfigurationTarget.Global, | ||
| } as const; | ||
|
|
||
| export type ConfigurationTargetType = | ||
| (typeof CONFIGURATION_TARGETS)[keyof typeof CONFIGURATION_TARGETS]; | ||
| export type ConfigKeyType = (typeof CONFIG_KEYS)[keyof typeof CONFIG_KEYS]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| import * as vscode from "vscode"; | ||
| import { ButtonConfig } from "./types"; | ||
| import { | ||
| CONFIG_SECTION, | ||
| CONFIG_KEYS, | ||
| CONFIGURATION_TARGETS, | ||
| VS_CODE_CONFIGURATION_TARGETS, | ||
| ConfigurationTargetType, | ||
| } from "./config-constants"; | ||
|
|
||
| export class ConfigManager { | ||
| static getCurrentConfigurationTarget(): ConfigurationTargetType { | ||
| const config = vscode.workspace.getConfiguration(CONFIG_SECTION); | ||
| return config.get<ConfigurationTargetType>( | ||
| CONFIG_KEYS.CONFIGURATION_TARGET, | ||
| CONFIGURATION_TARGETS.WORKSPACE | ||
| ); | ||
| } | ||
|
|
||
| static getVSCodeConfigurationTarget(): vscode.ConfigurationTarget { | ||
| const currentTarget = this.getCurrentConfigurationTarget(); | ||
| return VS_CODE_CONFIGURATION_TARGETS[currentTarget]; | ||
| } | ||
|
|
||
| static async updateConfigurationTarget( | ||
| target: ConfigurationTargetType | ||
| ): Promise<void> { | ||
| try { | ||
| const config = vscode.workspace.getConfiguration(CONFIG_SECTION); | ||
| await config.update( | ||
| CONFIG_KEYS.CONFIGURATION_TARGET, | ||
| target, | ||
| vscode.ConfigurationTarget.Global // Configuration target setting itself should always be global | ||
| ); | ||
|
|
||
| const targetMessage = | ||
| target === CONFIGURATION_TARGETS.GLOBAL | ||
| ? "user settings (shared across all projects)" | ||
| : "workspace settings (project-specific)"; | ||
|
|
||
| vscode.window.showInformationMessage( | ||
| `Configuration target changed to: ${targetMessage}` | ||
| ); | ||
| } catch (error) { | ||
| console.error("Failed to update configuration target:", error); | ||
| vscode.window.showErrorMessage( | ||
| "Failed to update configuration target. Please try again." | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| static async updateButtonConfiguration( | ||
| buttons: ButtonConfig[] | ||
| ): Promise<void> { | ||
| try { | ||
| const config = vscode.workspace.getConfiguration(CONFIG_SECTION); | ||
| const target = this.getVSCodeConfigurationTarget(); | ||
|
|
||
| await config.update(CONFIG_KEYS.BUTTONS, buttons, target); | ||
|
|
||
| const currentTarget = this.getCurrentConfigurationTarget(); | ||
| const targetMessage = | ||
| currentTarget === CONFIGURATION_TARGETS.GLOBAL | ||
| ? "user settings" | ||
| : "workspace settings"; | ||
|
|
||
| vscode.window.showInformationMessage( | ||
| `Configuration updated successfully in ${targetMessage}!` | ||
| ); | ||
| } catch (error) { | ||
| console.error("Failed to update configuration:", error); | ||
| vscode.window.showErrorMessage( | ||
| "Failed to update configuration. Please try again." | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| static getConfigDataForWebview(configReader: { | ||
| getButtons(): ButtonConfig[]; | ||
| }): { | ||
| buttons: ButtonConfig[]; | ||
| configurationTarget: ConfigurationTargetType; | ||
| } { | ||
| return { | ||
| buttons: configReader.getButtons(), | ||
| configurationTarget: this.getCurrentConfigurationTarget(), | ||
| }; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.