refactor: add zustand-based central state store#213
Merged
kubrickcode merged 2 commits intomainfrom Dec 2, 2025
Merged
Conversation
- Add zustand, zundo dependencies - Create AppStore (buttons, buttonSets, configTarget, activeSet) - Support selective subscription via subscribeWithSelector middleware - Provide singleton pattern and reset function for testing fix #194
Add one-way Settings → Store sync layer - StoreSync class: detect settings changes and auto-update Store - Extract resolveButtonsWithFallback utility to eliminate duplicate fallback logic - Apply guard flag pattern for future bidirectional sync fix #194
kubrickcode
changed the title
Owner
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-executed architectural change by adding a central state store using Zustand. The new AppStore and StoreSync components are well-structured, thoroughly tested, and adhere to the project's coding conventions. The refactoring to extract resolveButtonsWithFallback also improves code modularity. My review includes suggestions to improve the atomicity of state updates for better performance and consistency, and a note on an unused dependency.
Owner
Author
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one-way Settings → Store sync layer
fix #194