Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): exclude jwt.io #2168

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix(lint): exclude jwt.io #2168

merged 1 commit into from
Feb 7, 2025

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Feb 7, 2025

https://jwt.io/ is clearly blocking GH requests - it works normally from a browser, we need to exclude it to make the link checker pass

image

https://github.com/kumahq/kuma-website/actions/runs/13179405471/job/36786218554?pr=2165#step:6:27

Did you sign your commit? Instructions yes

Have you read Contributing guidelines? yes

https://jwt.io/ is clearly blocking GH requests - it works normally from a browser, we need to exclude it to make the link checker pass

Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
@slonka slonka requested a review from a team as a code owner February 7, 2025 08:51
@slonka slonka requested review from Automaat and lukidzi and removed request for a team February 7, 2025 08:51
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 48cd0c5
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/67a5c984c5edd200089f89e1
😎 Deploy Preview https://deploy-preview-2168--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🔴 down 21 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@slonka slonka merged commit 4052532 into master Feb 7, 2025
16 of 17 checks passed
@slonka slonka deleted the exclude-jwt-io branch February 7, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants