Merge pull request #2 from kumparan/hotfix/missing-connection-close

Hotfix: missing connection close
kumparan · Jan 25, 2023 · ef0ea84 · ef0ea84
2 parents 3c63539 + 69586fd
commit ef0ea84
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/LICENSE b/LICENSE
@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2022 kumparan
+Copyright (c) 2023 kumparan
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/restrix.go b/restrix.go
@@ -136,6 +136,8 @@ func (b Breaker) init(name string) (state string, openStateTTL time.Duration, er
 	ns := newNamespacer(name)
 
 	conn := b.redisPool.Get()
+	defer conn.Close()
+
 	err = conn.Send("MULTI")
 	if err != nil {
 		return
@@ -166,6 +168,8 @@ func (b Breaker) preRun(name string) (reqCount, errCount int, err error) {
 	ns := newNamespacer(name)
 
 	conn := b.redisPool.Get()
+	defer conn.Close()
+
 	err = conn.Send("MULTI")
 	if err != nil {
 		return
@@ -210,6 +214,8 @@ func (b Breaker) flipClose(name string) (err error) {
 	ns := newNamespacer(name)
 
 	conn := b.redisPool.Get()
+	defer conn.Close()
+
 	err = conn.Send("MULTI")
 	if err != nil {
 		return
@@ -239,6 +245,8 @@ func (b Breaker) flipOpen(name string) (err error) {
 	ns := newNamespacer(name)
 
 	conn := b.redisPool.Get()
+	defer conn.Close()
+
 	err = conn.Send("MULTI")
 	if err != nil {
 		return
@@ -268,6 +276,8 @@ func (b Breaker) recordError(name string) (err error) {
 	ns := newNamespacer(name)
 
 	conn := b.redisPool.Get()
+	defer conn.Close()
+
 	err = conn.Send("MULTI")
 	if err != nil {
 		return