Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @austintwang,
I created faster version of modisco with extra feature and we are using this version in our package: https://github.com/Genentech/decima.
Copying the original PR from modisco-lite repo: jmschrei/tfmodisco-lite#75
"""
Hi @jmschrei,
See the number of features implemented for faster modisco-lite where each commit implements one feature:
jmschrei/tfmodisco-lite@381cf29 unit tested and cli refactored with click: See the unit-test which check results are exactly same with original. You can rerun this test-case in each downstream commits to confirm results are exactly same.
jmschrei/tfmodisco-lite@f7f5b94 logging and progress bars added: Logging and progress bars are added. You can check how long each step is taking with improved logging. fixes jmschrei/tfmodisco-lite#45
jmschrei/tfmodisco-lite@c0f38c6 multiprocessing for reporting: Multi-threading for reporting step which runs tomtom for each pattern
jmschrei/tfmodisco-lite@5e85b03 add support for calling only positive or negative patterns
jmschrei/tfmodisco-lite@bd274ef stranded modisco. fixes jmschrei/tfmodisco-lite#69 and fixes jmschrei/tfmodisco-lite#57
jmschrei/tfmodisco-lite@96e2ba4 progressbar for numba functions steps with thread safe accumulator
Let me know if you have further comments.
"""