Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harry Potter Quiz Game #5140

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Harry Potter Quiz Game #5140

merged 3 commits into from
Aug 10, 2024

Conversation

sweta-singh28
Copy link
Contributor

PR Description πŸ“œ

Added a new game.

Fixes #5133


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) πŸ“Έ

Screenshot 2024-08-09 145254

Screenshot 2024-08-09 141828

Screenshot 2024-08-09 144901

WhatsApp.Video.2024-08-09.at.16.08.27_8a99962c.mp4


Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented Aug 9, 2024

Thank you @sweta-singh28 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

@sweta-singh28 sweta-singh28 changed the title Harry Harry Potter Quiz Game Aug 9, 2024
@sweta-singh28
Copy link
Contributor Author

@kunjgit sir, done.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your game entry in main readme. Md file of the repo refer other entries for the format

@@ -3,7 +3,7 @@
const generateLiTags = (gamesData, searchText = "") => {
const liTags = [];
searchText = searchText.trim().toLowerCase(); // Trim whitespace and convert to lowercase
let lengthOfJson = Object.keys(gamesData).length; // get the no. of games of Json to list them all
let lengthOfJson = Object.keys(gamesData).length+10; // get the no. of games of Json to list them all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 100 from the end if not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishita-43 mam, It is needed because due to some unknown issue games after 639 are not gettingΒ rendered.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if this way it works fine we will approve

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you need to enter your game name in the readme file of the repo please do this with the link format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sweta-singh28
Copy link
Contributor Author

@ishita-43 maam, done.

@ishita-43 ishita-43 added Ready to merge πŸ₯³ level3 Adding new features gssoc GSSoC24 program label labels Aug 10, 2024
@sweta-singh28
Copy link
Contributor Author

@kunjgit sir, Could you please merge this PR asap cause Today is the last day for GSSoC contributions.

@kunjgit kunjgit merged commit 8dc403f into kunjgit:main Aug 10, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 10, 2024

Thank you @sweta-singh28 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge πŸ₯³
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Harry Potter wizard quiz game.
3 participants