-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harry Potter Quiz Game #5140
Harry Potter Quiz Game #5140
Conversation
Thank you @sweta-singh28 ,for creating the PR and contributing to our GameZone π |
@kunjgit sir, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add your game entry in main readme. Md file of the repo refer other entries for the format
@@ -3,7 +3,7 @@ | |||
const generateLiTags = (gamesData, searchText = "") => { | |||
const liTags = []; | |||
searchText = searchText.trim().toLowerCase(); // Trim whitespace and convert to lowercase | |||
let lengthOfJson = Object.keys(gamesData).length; // get the no. of games of Json to list them all | |||
let lengthOfJson = Object.keys(gamesData).length+10; // get the no. of games of Json to list them all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove 100 from the end if not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishita-43 mam, It is needed because due to some unknown issue games after 639 are not gettingΒ rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, if this way it works fine we will approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you need to enter your game name in the readme file of the repo please do this with the link format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@ishita-43 maam, done. |
@kunjgit sir, Could you please merge this PR asap cause Today is the last day for GSSoC contributions. |
Thank you @sweta-singh28 , for your valuable time and contribution in our GameZone π. |
PR Description π
Added a new game.
Fixes #5133
Mark the task you have completed β
Add your screenshots(Optional) πΈ
WhatsApp.Video.2024-08-09.at.16.08.27_8a99962c.mp4
Thank you soo much for contributing to our repository π